Bugzilla – Attachment 31343 Details for
Bug 11319
Marc modification templates improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11395: Raise an alert if control field is used
Bug-11395-Raise-an-alert-if-control-field-is-used.patch (text/plain), 1.84 KB, created by
Jonathan Druart
on 2014-09-03 13:11:11 UTC
(
hide
)
Description:
Bug 11395: Raise an alert if control field is used
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-09-03 13:11:11 UTC
Size:
1.84 KB
patch
obsolete
>From d787dd0abae8043f0c80d3ea847a03b56c5d3bd7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 3 Sep 2014 15:08:39 +0200 >Subject: [PATCH] Bug 11395: Raise an alert if control field is used > >If a control field is used with a copy or move action, the interface >should block the user in some cases: >- If a control field is used with a regular field >- The subfield should be empty > >http://bugs.koha-community.org/show_bug.cgi?id=11319 >--- > .../prog/en/modules/tools/marc_modification_templates.tt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >index 9a1befb..222de22 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >@@ -23,6 +23,16 @@ $(document).ready(function() { > alert(_("The destination should be filled.")); > return false; > } >+ if ( ( $("#to_field").val() <= 10 && $("#to_subfield").val().length > 0 ) || >+ ( $("#from_field").val() <= 10 && $("#from_subfield").val().length > 0 ) ) { >+ alert(_("If the field is a control field, the subfield should be empty")); >+ return false; >+ } >+ if ( ( $("#from_field").val() <= 10 && $("#to_subfield").val().length == 0 ) || >+ ( $("#to_field").val() <= 10 && $("#from_subfield").val().length == 0 ) ) { >+ alert(_("A control field cannot be used with a regular field.")); >+ return false; >+ } > } > if ( action == 'update_field' ) { > if ( $("#from_subfield").val().length <= 0 ) { >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11319
:
23206
|
23414
|
23415
|
23416
|
23417
|
23418
|
23419
|
24650
|
25751
|
25752
|
25753
|
25754
|
25755
|
28988
|
28989
|
28990
|
28991
|
28992
|
29497
|
29498
|
29499
|
29500
|
29501
|
31343
|
33029
|
33030
|
33038
|
33039
|
33040
|
33041
|
33042
|
33043
|
33044