Bugzilla – Attachment 31452 Details for
Bug 12884
Get rid of redefined subroutine warnings from dateaccessioned.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 128840: Get rid of redefined subroutine warnings in dateaccessioned.pl
Bug-128840-Get-rid-of-redefined-subroutine-warning.patch (text/plain), 1.25 KB, created by
Marcel de Rooy
on 2014-09-08 11:37:37 UTC
(
hide
)
Description:
Bug 128840: Get rid of redefined subroutine warnings in dateaccessioned.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-09-08 11:37:37 UTC
Size:
1.25 KB
patch
obsolete
>From cabdcd51f95f4f3d0d2c07b4ab09fb959f2e50bc Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 8 Sep 2014 13:21:17 +0200 >Subject: [PATCH] Bug 128840: Get rid of redefined subroutine warnings in > dateaccessioned.pl >Content-Type: text/plain; charset=utf-8 > >Most value_builder scripts have use warnings commented since they redefine subroutines like plugin_javascript etc. and they would create a lot of loglines. >The dateaccessioned script in this folder does not have it commented; so it creates loglines. > >While we wait for the real solution for those redefines, I am at least consistent when commenting the use warnings here.. ;) > >Test plan: >Edit an item. >Check log. >Apply patch. >Edit an item. >Check log. >--- > cataloguing/value_builder/dateaccessioned.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/cataloguing/value_builder/dateaccessioned.pl b/cataloguing/value_builder/dateaccessioned.pl >index 5e834a4..467f77c 100755 >--- a/cataloguing/value_builder/dateaccessioned.pl >+++ b/cataloguing/value_builder/dateaccessioned.pl >@@ -18,7 +18,7 @@ > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > use strict; >-use warnings; >+#use warnings; #get rid of redefined subroutine warnings > > =head1 > >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12884
:
31452
|
31453
|
31578
|
31632
|
31636