Bugzilla – Attachment 31512 Details for
Bug 11668
Untranslatable "Total" in borrowers stats and other reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix untranslatable "Total" in more files
Fix-untranslatable-Total-in-more-files.patch (text/plain), 7.56 KB, created by
Marc Véron
on 2014-09-10 15:41:39 UTC
(
hide
)
Description:
Fix untranslatable "Total" in more files
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-09-10 15:41:39 UTC
Size:
7.56 KB
patch
obsolete
>From 085a6f55702aa6a43ece8c8ead7585bd120c1f23 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sun, 7 Sep 2014 21:08:01 +0200 >Subject: [PATCH] Fix untranslatable "Total" in more files > >This patch fixes untranslatable "Total" in following files: > >reports/acquisitions_stats.pl >reports/bor_issues_top.pl >reports/borrowers_out.pl >reports/cat_issues_top.pl >reports/catalogue_stats.pl >reports/issues_avg_stats.pl >reports/issues_stats.pl > >To test follow test plan from first patch as appropiate. > >http://bugs.koha-community.org/show_bug.cgi?id=11668 > >(Missing use Koha::I18N; added) >--- > reports/acquisitions_stats.pl | 5 +++-- > reports/bor_issues_top.pl | 5 +++-- > reports/borrowers_out.pl | 5 +++-- > reports/cat_issues_top.pl | 5 +++-- > reports/catalogue_stats.pl | 5 +++-- > reports/issues_avg_stats.pl | 5 +++-- > reports/issues_stats.pl | 5 +++-- > reports/reserves_stats.pl | 4 ++-- > 8 files changed, 23 insertions(+), 16 deletions(-) > >diff --git a/reports/acquisitions_stats.pl b/reports/acquisitions_stats.pl >index b19bf8e..e7bc976 100755 >--- a/reports/acquisitions_stats.pl >+++ b/reports/acquisitions_stats.pl >@@ -29,6 +29,7 @@ use C4::Circulation; > use C4::Dates qw/format_date format_date_in_iso/; > use C4::Branch; > use C4::Biblio; >+use Koha::I18N; > > =head1 NAME > >@@ -94,7 +95,7 @@ if ($do_it) { > foreach my $col (@$cols) { > print $col->{coltitle} . $sep; > } >- print "Total\n"; >+ print gettext("Total") . "\n"; > foreach my $line (@$lines) { > my $x = $line->{loopcell}; > print $line->{rowtitle} . $sep; >@@ -104,7 +105,7 @@ if ($do_it) { > print $line->{totalrow}; > print "\n"; > } >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > foreach my $col (@$cols) { > print $sep. $col->{totalcol}; >diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl >index f8ee8e8..ad0c9bf 100755 >--- a/reports/bor_issues_top.pl >+++ b/reports/bor_issues_top.pl >@@ -30,6 +30,7 @@ use C4::Members; > use C4::Reports; > use C4::Debug; > use C4::Dates qw(format_date format_date_in_iso); >+use Koha::I18N; > > =head1 NAME > >@@ -86,7 +87,7 @@ if ($do_it) { > print @$results[0]->{line} ."/". @$results[0]->{column} .$sep; > # Other header > print join($sep, map {$_->{coltitle}} @$cols); >- print $sep . "Total\n"; >+ print $sep . gettext("Total") . "\n"; > # Table > foreach my $line ( @$lines ) { > my $x = $line->{loopcell}; >@@ -96,7 +97,7 @@ if ($do_it) { > print "\n"; > } > # footer >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > print join($sep, map {$_->{totalcol}} @$cols); > print $sep.@$results[0]->{total}; >diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl >index 9687234..5f87533 100755 >--- a/reports/borrowers_out.pl >+++ b/reports/borrowers_out.pl >@@ -29,6 +29,7 @@ use C4::Circulation; > use C4::Reports; > use C4::Members; > use C4::Dates qw/format_date_in_iso/; >+use Koha::I18N; > > =head1 NAME > >@@ -83,7 +84,7 @@ if ($do_it) { > foreach my $col ( @$cols ) { > print $col->{coltitle}.$sep; > } >- print "Total\n"; >+ print gettext("Total") . "\n"; > # Table > foreach my $line ( @$lines ) { > my $x = $line->{loopcell}; >@@ -96,7 +97,7 @@ if ($do_it) { > print "\n"; > } > # footer >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > foreach my $col ( @$cols ) { > print $sep.$col->{totalcol}; >diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl >index 893fd21..80680e6 100755 >--- a/reports/cat_issues_top.pl >+++ b/reports/cat_issues_top.pl >@@ -30,6 +30,7 @@ use C4::Circulation; > use C4::Reports; > use C4::Dates qw/format_date format_date_in_iso/; > use C4::Members; >+use Koha::I18N; > > =head1 NAME > >@@ -89,7 +90,7 @@ if ($do_it) { > foreach my $col ( @$cols ) { > print $col->{coltitle}.$sep; > } >- print "Total\n"; >+ print gettext("Total") . "\n"; > # Table > foreach my $line ( @$lines ) { > my $x = $line->{loopcell}; >@@ -101,7 +102,7 @@ if ($do_it) { > print "\n"; > } > # footer >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > foreach my $col ( @$cols ) { > print $sep.$col->{totalcol}; >diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl >index a19334a..31ea745 100755 >--- a/reports/catalogue_stats.pl >+++ b/reports/catalogue_stats.pl >@@ -28,6 +28,7 @@ use C4::Output; > use C4::Koha; > use C4::Reports; > use C4::Circulation; >+use Koha::I18N; > > =head1 NAME > >@@ -86,7 +87,7 @@ if ($do_it) { > foreach my $col ( @$cols ) { > print $col->{coltitle}.$sep; > } >- print "Total\n"; >+ print gettext("Total") . "\n"; > foreach my $line ( @$lines ) { > my $x = $line->{loopcell}; > print $line->{rowtitle}.$sep; >@@ -96,7 +97,7 @@ if ($do_it) { > print $line->{totalrow}; > print "\n"; > } >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > foreach my $col ( @$cols ) { > print $sep.$col->{totalcol}; >diff --git a/reports/issues_avg_stats.pl b/reports/issues_avg_stats.pl >index 3781d37..f2d7838 100755 >--- a/reports/issues_avg_stats.pl >+++ b/reports/issues_avg_stats.pl >@@ -30,6 +30,7 @@ use C4::Circulation; > use C4::Reports; > use C4::Dates qw/format_date format_date_in_iso/; > use Date::Calc qw(Delta_Days); >+use Koha::I18N; > > =head1 NAME > >@@ -91,7 +92,7 @@ if ($do_it) { > foreach my $col ( @$cols ) { > print $col->{coltitle}.$sep; > } >- print "Total\n"; >+ print gettext("Total") . "\n"; > # Table > foreach my $line ( @$lines ) { > my $x = $line->{loopcell}; >@@ -103,7 +104,7 @@ if ($do_it) { > print "\n"; > } > # footer >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > foreach my $col ( @$cols ) { > print $sep.$col->{totalcol}; >diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl >index 0ab0143..1fbf11c 100755 >--- a/reports/issues_stats.pl >+++ b/reports/issues_stats.pl >@@ -33,6 +33,7 @@ use C4::Circulation; > use C4::Reports; > use C4::Dates qw/format_date format_date_in_iso/; > use C4::Members; >+use Koha::I18N; > > =head1 NAME > >@@ -107,7 +108,7 @@ if ($do_it) { > foreach my $col ( @$cols ) { > print $col->{coltitle}.$sep; > } >- print "Total\n"; >+ print gettext("Total") . "\n"; > # Table > foreach my $line ( @$lines ) { > my $x = $line->{loopcell}; >@@ -116,7 +117,7 @@ if ($do_it) { > print $line->{totalrow}, "\n"; > } > # footer >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > print map {$sep.$_->{totalcol}} @$cols; > print $sep.@$results[0]->{total}; >diff --git a/reports/reserves_stats.pl b/reports/reserves_stats.pl >index 11fcb8e..50fa725 100755 >--- a/reports/reserves_stats.pl >+++ b/reports/reserves_stats.pl >@@ -115,7 +115,7 @@ if ($do_it) { > foreach my $col ( @$cols ) { > print $col->{coltitle}.$sep; > } >- print "Total\n"; >+ print gettext("Total") . "\n"; > # Table > foreach my $line ( @$lines ) { > my $x = $line->{loopcell}; >@@ -124,7 +124,7 @@ if ($do_it) { > print $line->{totalrow}, "\n"; > } > # footer >- print "TOTAL"; >+ print gettext("TOTAL"); > $cols = @$results[0]->{loopfooter}; > print map {$sep.$_->{totalcol}} @$cols; > print $sep.@$results[0]->{total}; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11668
:
27936
|
31425
|
31438
|
31512
|
31513
|
32698
|
32699
|
32711
|
32712
|
32713
|
36794