Attachment 31518 Details for Bug 11399 – followup : QA fixes

[patch] followup : QA fixes

0001-Bug-11399-QA-fixes.patch (text/plain), 1.37 KB, created by Stéphane Delaune on 2014-09-11 08:42:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stéphane Delaune

Created: 2014-09-11 08:42:53 UTC

Size: 1.37 KB

patch

obsolete

>From 79c97e69f2896ae85702a5a192ba2e002ceaffa7 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?St=C3=A9phane=20Delaune?= <stephane.delaune@biblibre.com>
>Date: Thu, 11 Sep 2014 10:29:49 +0200
>Subject: [PATCH] Bug 11399: QA fixes
>
>---
> misc/batchRebuildItemsTables.pl | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/misc/batchRebuildItemsTables.pl b/misc/batchRebuildItemsTables.pl
>index e05e4d4..2398bdb 100755
>--- a/misc/batchRebuildItemsTables.pl
>+++ b/misc/batchRebuildItemsTables.pl
>@@ -1,7 +1,5 @@
> #!/usr/bin/perl
>-use 5.10.0;
>-use strict;
>-use warnings;
>+use Modern::Perl;
> use Getopt::Long;
> use C4::Context;
> use C4::Biblio;
>@@ -94,8 +92,10 @@ while ( my ( $biblionumber, $biblioitemnumber, $frameworkcode ) = $sth->fetchrow
>     }
> }
> 
>-$dbh->do("UPDATE systempreferences SET value=$CataloguingLog WHERE variable='CataloguingLog'");
>-$dbh->do("UPDATE systempreferences SET value=$dontmerge where variable='dontmerge'");
>+my $sthCataloguingLog = $dbh->prepare("UPDATE systempreferences SET value=? WHERE variable='CataloguingLog'");
>+$sthCataloguingLog->execute($CataloguingLog);
>+my $sthdontmerge = $dbh->prepare("UPDATE systempreferences SET value=? WHERE variable='dontmerge'");
>+$sthdontmerge->execute($dontmerge);
> $dbh->commit() unless $test_parameter;
> my $timeneeded = time() - $starttime;
> print "$count MARC record done in $timeneeded seconds\n";
>-- 
>1.9.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 11399: 23575 | 23593 | 29156 | 31518 | 32511 | 32512