Attachment 31568 Details for Bug 12913 – [SIGNED OFF] Bug 12913 - wrong inventory results when notforloan filter is not used

[patch] [SIGNED OFF] Bug 12913 - wrong inventory results when notforloan filter is not used

SIGNED-OFF-Bug-12913---wrong-inventory-results-whe.patch (text/plain), 3.44 KB, created by Nick Clemens (kidclamp) on 2014-09-13 00:43:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2014-09-13 00:43:57 UTC

Size: 3.44 KB

patch

obsolete

>From c8f5ba7a9cb1427c9dacbbe7f9a84fd83caf67c4 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Fri, 12 Sep 2014 15:21:18 +0200
>Subject: [PATCH] [SIGNED OFF] Bug 12913 - wrong inventory results when
> notforloan filter is not used
>
>In inventory tool, there is a test on scanned items notforloan value : if the value is not one of authorized values, the inventory results displays the problem "Change item status".
>The bug is that if notforloan filter is not used, the notforloan values array is not filled and so all scanned items are marked with this problem.
>
>Test plan :
>- Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN'
>- Check the authorized value category has at least value '0'
>- Create a new value in this category, for example '9'
>- Create a biblio with default framework
>- Create an item with barcode='000AAA1', callnumber='ZZZAAA1' and notforloan=0
>- Create an item with barcode='000AAA2', callnumber='ZZZAAA2' and notforloan=9
>- Delete new value created above, for example '9'
>- Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2'
>- Go to inventory tool : /cgi-bin/koha/tools/inventory.pl
>- Choose file in 'Barcode file'
>- Enter item callnumber between 'ZZZ' and 'ZZZZ'
>- Check 'Compare barcodes list to results'
>- Submit
>=> without patch, you get 2 results with problem 'Change item status' even for item with notforloan=0
>=> with patch, you get 1 result with 'Change item status' on item with notforloan=9
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>---
> tools/inventory.pl |   20 ++++----------------
> 1 file changed, 4 insertions(+), 16 deletions(-)
>
>diff --git a/tools/inventory.pl b/tools/inventory.pl
>index 6a5ddc4..53e51f5 100755
>--- a/tools/inventory.pl
>+++ b/tools/inventory.pl
>@@ -93,6 +93,7 @@ for my $fwk (keys %$frameworks){
> }
> 
> my $statuses = [];
>+my @notforloans;
> for my $statfield (qw/items.notforloan items.itemlost items.withdrawn items.damaged/){
>     my $hash = {};
>     $hash->{fieldname} = $statfield;
>@@ -101,6 +102,9 @@ for my $statfield (qw/items.notforloan items.itemlost items.withdrawn items.dama
>         my $arr = GetAuthorisedValues($hash->{authcode});
>         $hash->{values} = $arr;
>         push @$statuses, $hash;
>+        if ( $statfield eq 'items.notforloan') {
>+            @notforloans = map { $_->{'authorised_value'} } @$arr;
>+        }
>     }
> }
> 
>@@ -116,16 +120,6 @@ for my $authvfield (@$statuses) {
>     }
> }
> 
>-my $notforloanlist;
>-my $statussth = '';
>-for my $authvfield (@$statuses) {
>-    if ( scalar @{$staton->{$authvfield->{fieldname}}} > 0 ){
>-        my $joinedvals = join ',', @{$staton->{$authvfield->{fieldname}}};
>-        $statussth .= "$authvfield->{fieldname} in ($joinedvals) and ";
>-        $notforloanlist = $joinedvals if ($authvfield->{fieldname} eq "items.notforloan");
>-    }
>-}
>-$statussth =~ s, and $,,g;
> $template->param(
>     branchloop               => \@branch_loop,
>     authorised_values        => \@authorised_value_list,
>@@ -138,14 +132,8 @@ $template->param(
>     branch                   => $branch,
>     datelastseen             => $datelastseen,
>     compareinv2barcd         => $compareinv2barcd,
>-    notforloanlist           => $notforloanlist
> );
> 
>-my @notforloans;
>-if (defined $notforloanlist) {
>-    @notforloans = split(/,/, $notforloanlist);
>-}
>-
> my @scanned_items;
> my @errorloop;
> if ( $uploadbarcodes && length($uploadbarcodes) > 0 ) {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 12913: 31553 | 31568 | 31733 | 61670 | 61671 | 61674