Bugzilla – Attachment 31575 Details for
Bug 12915
Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 12915 - Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable
Signed-off-Bug-12915---Convert-checkouts-table-to-.patch (text/plain), 2.46 KB, created by
Marc Véron
on 2014-09-13 12:41:39 UTC
(
hide
)
Description:
[Signed-off] Bug 12915 - Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-09-13 12:41:39 UTC
Size:
2.46 KB
patch
obsolete
>From 7e61f764c191b49d1c80dc136defe528ff68e0bc Mon Sep 17 00:00:00 2001 >From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> >Date: Sat, 13 Sep 2014 10:49:21 +0300 >Subject: [PATCH] [Signed-off] Bug 12915 - Convert checkouts table to ajax > datatable [3.16.x], AllowRenewalLimitOverride crashes > datatable >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >when user doesn't have the permission. > >TO REPLICATE:: > >load circ/circulate.pl with a user with only the following permissions: > circulate_remaining_permissions > catalogue > >observe checkouts and holds not loading. Actually this crashes all javascript on the page! > >Reproduced bug without patch. Applied patch, page displays as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >index df9ca78..6f02b79 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >@@ -3,7 +3,7 @@ > var CIRCULATION_RETURNED = _("Returned"); > var CIRCULATION_NOT_RETURNED = _("Unable to return"); > var CIRCULATION_RENEWED_DUE = _("Renewed, due:"); >- var CIRCULATION_RENEW_FAILED = _("Renew failed:") >+ var CIRCULATION_RENEW_FAILED = _("Renew failed:"); > var NOT_CHECKED_OUT = _("not checked out"); > var TOO_MANY_RENEWALS = _("too many renewals"); > var ON_RESERVE = _("on reserve"); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 9734c0f..3fe844b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -32,7 +32,7 @@ var theme = "[% theme %]"; > var borrowernumber = "[% borrowernumber %]"; > var branchcode = "[% branch %]"; > var exports_enabled = "[% exports_enabled %]"; >-var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; >+var AllowRenewalLimitOverride = "[% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]"; > var relatives_borrowernumbers = new Array(); > [% FOREACH b IN relatives_borrowernumbers %] > relatives_borrowernumbers.push("[% b %]"); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12915
:
31570
|
31571
| 31575