Attachment 31609 Details for Bug 12918 – [PASSED QA] Bug 12918: fix failing test case

[patch] [PASSED QA] Bug 12918: fix failing test case

PASSED-QA-Bug-12918-fix-failing-test-case.patch (text/plain), 1.59 KB, created by Kyle M Hall (khall) on 2014-09-15 13:22:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-09-15 13:22:25 UTC

Size: 1.59 KB

patch

obsolete

>From 5d321828ae9808f5d197b8fc4d7359bd43e3e82f Mon Sep 17 00:00:00 2001
>From: Robin Sheat <robin@catalyst.net.nz>
>Date: Mon, 15 Sep 2014 14:08:03 +1200
>Subject: [PATCH] [PASSED QA] Bug 12918: fix failing test case
>
>A bug in a test case causes test case failure. It also required a
>database, so I'm moving it out of the way.
>
>Test plan:
>1) prove -v t/db_dependent/Templates.t
>   -- bombs!
>2) apply patch
>3) prove -v t/db_dependent/Templates.t
>   -- works!
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/{ => db_dependent}/Templates.t |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> rename t/{ => db_dependent}/Templates.t (97%)
>
>diff --git a/t/Templates.t b/t/db_dependent/Templates.t
>similarity index 97%
>rename from t/Templates.t
>rename to t/db_dependent/Templates.t
>index f50297b..ade6f1d 100755
>--- a/t/Templates.t
>+++ b/t/db_dependent/Templates.t
>@@ -40,7 +40,7 @@ my $columns = C4::Templates::GetColumnDefs( $query );
> 
> is( ref( $columns ) eq 'HASH', 1, 'GetColumnDefs returns a hashref' );
> # get the tables names, sorted
>-my @keys = sort keys $columns;
>+my @keys = sort keys %$columns;
> is( scalar @keys, 5, "GetColumnDefs correctly returns the 5 tables defined in columns.def" );
> my @tables = ( 'biblio', 'biblioitems', 'borrowers', 'items', 'statistics');
> cmp_deeply( \@keys, \@tables, "GetColumnDefs returns the expected tables");
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 12918: 31588 | 31592 | 31602 | 31606 | 31609