Bugzilla – Attachment 31625 Details for
Bug 12844
Introduce a centralized way to display prices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12844: Remove the C4::Output::FormatNumber subroutine
0002-Bug-12844-Remove-the-C4-Output-FormatNumber-subrouti.patch (text/plain), 1.84 KB, created by
Paola Rossi
on 2014-09-16 12:50:42 UTC
(
hide
)
Description:
Bug 12844: Remove the C4::Output::FormatNumber subroutine
Filename:
MIME Type:
Creator:
Paola Rossi
Created:
2014-09-16 12:50:42 UTC
Size:
1.84 KB
patch
obsolete
>From 2fc3f2a2ffda08d23aa4792b1df11533b4a7325c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 28 Aug 2014 16:20:18 +0200 >Subject: [PATCH 2/4] Bug 12844: Remove the C4::Output::FormatNumber > subroutine > >This subroutine is now useless. > >Test plan: > git grep FormatNumber >should not return any result in pl and pm files. > >Signed-off-by: Paola Rossi <paola.rossi@cineca.it> >--- > C4/Output.pm | 28 +--------------------------- > 1 file changed, 1 insertion(+), 27 deletions(-) > >diff --git a/C4/Output.pm b/C4/Output.pm >index 324cf69..d09bba7 100644 >--- a/C4/Output.pm >+++ b/C4/Output.pm >@@ -53,7 +53,7 @@ BEGIN { > setlanguagecookie getlanguagecookie pagination_bar parametrized_url > ); > push @EXPORT, qw( >- &output_html_with_http_headers &output_ajax_with_http_headers &output_with_http_headers FormatData FormatNumber >+ &output_html_with_http_headers &output_ajax_with_http_headers &output_with_http_headers FormatData > ); > > } >@@ -67,32 +67,6 @@ C4::Output - Functions for managing output, is slowly being deprecated > =over 2 > =cut > >-=item FormatNumber >-=cut >-sub FormatNumber{ >-my $cur = GetCurrency; >-my $cur_format = C4::Context->preference("CurrencyFormat"); >-my $num; >- >-if ( $cur_format eq 'FR' ) { >- $num = new Number::Format( >- 'decimal_fill' => '2', >- 'decimal_point' => ',', >- 'int_curr_symbol' => $cur->{symbol}, >- 'mon_thousands_sep' => ' ', >- 'thousands_sep' => ' ', >- 'mon_decimal_point' => ',' >- ); >-} else { # US by default.. >- $num = new Number::Format( >- 'int_curr_symbol' => '', >- 'mon_thousands_sep' => ',', >- 'mon_decimal_point' => '.' >- ); >-} >-return $num; >-} >- > =item FormatData > > FormatData($data_hashref) >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12844
:
31258
|
31259
|
31260
|
31304
|
31618
|
31624
|
31625
|
31626
|
31627
|
31813
|
31826
|
32211
|
32229
|
32314
|
32315
|
32316
|
32317
|
32318