Bugzilla – Attachment 31789 Details for
Bug 12740
It should not be possible to store empty news
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 12740 - It should not be possible to store empty news
SIGNED-OFF-Bug-12740---It-should-not-be-possible-t.patch (text/plain), 2.32 KB, created by
Mark Tompsett
on 2014-09-20 11:50:36 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 12740 - It should not be possible to store empty news
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2014-09-20 11:50:36 UTC
Size:
2.32 KB
patch
obsolete
>From 55d2133b54f6ceecacb9f8c7341f95ed8762a833 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sat, 13 Sep 2014 18:10:06 +0200 >Subject: [PATCH] [SIGNED OFF] Bug 12740 - It should not be possible to store > empty news > >This patch marks the title field as 'required' and it is not >longer possible to store a news without having at least a title. > >To test: >Got to Tools->News >Create news or edit existing news >Field "Title" should have a red label and should be marked as "required" >It should not be possible to save with empty field "Title" > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >NOTE: Only keeps the user from doing it. > Fails to handle the fake the url call case. >https://demo.library-admin.kohasystem.ca/cgi-bin/koha/tools/koha-news.pl?op=add&lang=&branch=&title=&from=&to=&number=&new= >--- > .../prog/en/modules/tools/koha-news.tt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >index 552fb6e..e1159f8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >@@ -119,8 +119,8 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div> > </select> > </li> > <li> >- <label for="title">Title: </label> >- <input id="title" size="30" type="text" name="title" value="[% new_detail.title %]" /> >+ <label for="title" class="required">Title: </label> >+ <input id="title" size="30" type="text" name="title" value="[% new_detail.title %]" required="required" class="required" /> <span class="required">Required</span> > </li> > <li> > <label for="from">Publication date: </label> >@@ -141,7 +141,8 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div> > [% END %] > </li> > <li><label for="new">News: </label> >- <textarea name="new" id="new" cols="75" rows="10">[% new_detail.new %]</textarea></li> >+ <textarea name="new" id="new" cols="75" rows="10">[% new_detail.new %]</textarea> >+ </li> > </ol> > </fieldset> > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12740
:
30647
|
31579
|
31788
|
31789
|
31790
|
31791
|
31804
|
31805
|
31806