Attachment 31846 Details for Bug 12876 – Bug 12876: (followup) remove useless diags

[patch] Bug 12876: (followup) remove useless diags

Bug-12876-followup-remove-useless-diags.patch (text/plain), 2.09 KB, created by Tomás Cohen Arazi (tcohen) on 2014-09-24 00:27:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2014-09-24 00:27:34 UTC

Size: 2.09 KB

patch

obsolete

>From 171b4e24b30ddceb04e45fb51c4adb6f921217a2 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Tue, 23 Sep 2014 21:07:08 -0300
>Subject: [PATCH] Bug 12876: (followup) remove useless diags
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>---
> t/db_dependent/Reserves.t | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index c32ab70..3ee2832 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -1,5 +1,20 @@
> #!/usr/bin/perl
> 
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
> use Modern::Perl;
> 
> use Test::More tests => 50;
>@@ -44,8 +59,7 @@ foreach my $addcat ('S', 'PT') {
>     $dbh->do("INSERT INTO categories (categorycode,hidelostitems,category_type) VALUES (?,?,?)",undef,($addcat, 0, $addcat eq 'S'? 'S': 'A')) unless GetBorrowercategory($addcat);
> }
> 
>-# Helper biblio.
>-diag("\nCreating biblio instance for testing.");
>+# Create a helper biblio
> my $bib = MARC::Record->new();
> my $title = 'Silence in the library';
> if( C4::Context->preference('marcflavour') eq 'UNIMARC' ) {
>@@ -63,8 +77,7 @@ else {
> my ($bibnum, $bibitemnum);
> ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');
> 
>-# Helper item for that biblio.
>-diag("Creating item instance for testing.");
>+# Create a helper item instance for testing
> my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
> 
> # Modify item; setting barcode.
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12876: 31393 | 31404 | 31406 | 31413 | 31414 | 31440 | 31441 | 31846