Bugzilla – Attachment 32014 Details for
Bug 12974
Argument "" isn't numeric in numeric gt (>) in opac-results.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt
Bug-12974---Argument--isnt-numeric-in-numeric-gt--.patch (text/plain), 1.90 KB, created by
Marc Véron
on 2014-10-06 14:34:39 UTC
(
hide
)
Description:
Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-10-06 14:34:39 UTC
Size:
1.90 KB
patch
obsolete
>From d5e9517f42b5fcefb64b8c00340fb2e570c0ed9f Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sat, 20 Sep 2014 21:38:02 +0200 >Subject: [PATCH] Bug 12974 - Argument "" isn't numeric in numeric gt (>) in > opac-results.tt > >If an item has no star ratings you get an error message in opac-error.log: >Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. > >To test: >In OPAC, search for a bilio that has no star ratings. >Check opac-error.log for message as above >Apply patch >Repeat search >Check opac-error.log again, there should be no more warnings > >(Fixed mistake with brackets, see comment #2) >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index b333458..72a3a89 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -460,7 +460,7 @@ > <input type="hidden" name="biblionumber" value="[% SEARCH_RESULT.biblionumber %]" /> > <input type="hidden" name="loggedinuser" value="[% loggedinuser %]" /> > >- [% IF ( SEARCH_RESULT.rating_total ) > 0 %] >+ [% IF SEARCH_RESULT.rating_total && SEARCH_RESULT.rating_total > 0 %] > <span id="rating_total_[% SEARCH_RESULT.biblionumber %]"> ([% SEARCH_RESULT.rating_total %] votes)</span> > [% ELSE %] > <br /> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12974
:
31794
|
32014
|
32015
|
32021