Bugzilla – Attachment 32050 Details for
Bug 9214
Show damaged status in the OPAC for items which are not for loan
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation
Bug-12937-Follow-up-Deleting-suggestions-should-as.patch (text/plain), 2.56 KB, created by
Biblibre Sandboxes
on 2014-10-07 19:31:02 UTC
(
hide
)
Description:
Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2014-10-07 19:31:02 UTC
Size:
2.56 KB
patch
obsolete
>From 4f5a6428c9d3586782b34a364f4dbc2a657e57f8 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 17 Sep 2014 08:31:27 -0400 >Subject: [PATCH] Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation > >This minor follow-up revises the language a bit: Adding missing question >marks and using the more standard prompt "Please select at least one..." > >To test, follow the previous test plan and confirm that the prompts are >improved: > >- go on the suggestion management page >- don't select any suggestion and try to delete (check the checkbox and > submit the form). Verify that you get an alert. >- select 1 suggestion and delete it, verify you get a confirmation > message >- select 1+ suggestions and delete it, verify you get a confirmation > message > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> > >Signed-off-by: amber@marlboro.edu <1> > >http://bugs.koha-community.org/show_bug.cgi?id=9214 >--- > .../prog/en/modules/suggestion/suggestion.tt | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 70d00ad..e3096c3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -141,16 +141,16 @@ $(document).ready(function() { > if ( action_delete_selected ) { > var suggestions_to_delete = $(this).find("input[name='edit_field']:checked"); > if ( suggestions_to_delete.length == 0 ) { >- alert(_("No suggestion to delete")); >+ alert(_("Please select at least one suggestion to delete")); > e.preventDefault(); > return false; > } else if ( suggestions_to_delete.length == 1 ) { >- if ( ! confirm(_("Are you sure you want to delete this suggestion")) ) { >+ if ( ! confirm(_("Are you sure you want to delete this suggestion?")) ) { > e.preventDefault(); > return false; > } > } else if ( suggestions_to_delete.length > 1 ) { >- if ( ! confirm(_("Are you sure you want to delete these suggestions")) ) { >+ if ( ! confirm(_("Are you sure you want to delete these suggestions?")) ) { > e.preventDefault(); > return false; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9214
:
32047
|
32048
|
32049
|
32050
|
32160
|
32161
|
32269
|
32270
|
33463
|
33464