Bugzilla – Attachment 32144 Details for
Bug 12999
Untranslatable string on enhanced_content.pref
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12999: Untranslatable string on enhanced_content.pref
SIGNED-OFF-Bug-12999-Untranslatable-string-on-enha.patch (text/plain), 2.10 KB, created by
Owen Leonard
on 2014-10-10 14:15:12 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12999: Untranslatable string on enhanced_content.pref
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-10-10 14:15:12 UTC
Size:
2.10 KB
patch
obsolete
>From 70ec5cd2e00abfe0554b849a96fd8309457c22cb Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Thu, 25 Sep 2014 21:35:29 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 12999: Untranslatable string on > enhanced_content.pref >Content-Type: text/plain; charset="utf-8" > >This patch modifies LangInstaller.pm to catch strings >on syspref files that have no associated syspref > >To test: >1) Update strings for your preffered language >2) Check that the string "you can only choose one source" >is not present on xx-YY-pref.po file > >3) Apply the patch >4) Update strings again >5) Check the strig now appears [ and another one :) ] > >Doing a diff before and after will show > # Enhanced Content > All > msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only > choose one source of cover images from below, otherwise Koha will show > the images from all sources selected." > msgstr "" > > # Local Use > msgid "local_use.pref## Nothing defined yet." > msgstr "" > >6) Translate the string >7) Install your language, check Administration > System preferences > > Enhanced content > All > (on your languge) and check the string is now translated > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > misc/translator/LangInstaller.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/translator/LangInstaller.pm b/misc/translator/LangInstaller.pm >index b89aaa8..6ced014 100644 >--- a/misc/translator/LangInstaller.pm >+++ b/misc/translator/LangInstaller.pm >@@ -172,7 +172,7 @@ sub add_prefs { > } > } > } >- elsif ( $element && $pref_name ) { >+ elsif ( $element ) { > $self->po_append( $self->{file} . "#$pref_name# $element", $comment ); > } > } >@@ -214,7 +214,7 @@ sub update_tab_prefs { > } > } > } >- elsif ( $element && $pref_name ) { >+ elsif ( $element ) { > my $id = $self->{file} . "#$pref_name# $element"; > my $text = $self->get_trans_text( $id ); > $p->[$i] = $text if $text; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12999
:
31885
|
31886
|
32144
|
32259
|
56441