Bugzilla – Attachment 32159 Details for
Bug 11990
Holds ratio report (circ/reserveratios.pl) sorts numeric values as text
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 11990 - Holds ratio report (circ/reserveratios.pl) sorts numeric values as text
SIGNED-OFF-Bug-11990---Holds-ratio-report-circrese.patch (text/plain), 2.04 KB, created by
Owen Leonard
on 2014-10-10 14:52:08 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 11990 - Holds ratio report (circ/reserveratios.pl) sorts numeric values as text
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-10-10 14:52:08 UTC
Size:
2.04 KB
patch
obsolete
>From 330e5cd76b59b5bb7dff94c1c9c07e61fd283fdd Mon Sep 17 00:00:00 2001 >From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> >Date: Wed, 8 Oct 2014 15:22:53 +0300 >Subject: [PATCH] [SIGNED-OFF] Bug 11990 - Holds ratio report > (circ/reserveratios.pl) sorts numeric values as text >Content-Type: text/plain; charset="utf-8" > >This patch makes columns Holds, Items and "Hold ratio" to sort >numerically instead of lexicographically. Also changes default sorting >column from "Holds" to "Hold ratio" because this is a hold ratios >-report, not hold count report. > >Also cleans up an excess aoColumn -definition, because aoColumns == >aoColumnDefs without target operator. No point in defining columns >twice. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/circ/reserveratios.tt | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >index dcc9d50..b12ffc3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >@@ -15,21 +15,10 @@ > function () { $(this).toggleClass("ulined") } > ); > $("#holdst").dataTable($.extend(true, {}, dataTablesDefaults, { >- "aaSorting": [ [0,'desc'], [3,'asc'] ], >+ "aaSorting": [ [2,'desc'], [3,'asc'] ], > "aoColumnDefs": [ >- { "aTargets": [ 8 ], "sType": "natural" }, >- { "aTargets": [ 3 ], "sType": "anti-the" } >- ], >- "aoColumns": [ >- null, >- null, >- null, >- { "sType": "anti-the" }, >- null, >- null, >- null, >- null, >- null >+ { "aTargets": [ 0,1,2,8 ], "sType": "natural" }, >+ { "aTargets": [ 3 ], "sType": "anti-the" }, > ], > "sPaginationType": "four_button" > })); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11990
:
26538
|
32060
|
32061
|
32159
|
32236