Bugzilla – Attachment 32168 Details for
Bug 8446
Shibboleth authentication
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] BUG8446, QA Followup: Minor Code Tidies
PASSED-QA-BUG8446-QA-Followup-Minor-Code-Tidies.patch (text/plain), 1.76 KB, created by
Katrin Fischer
on 2014-10-10 15:09:39 UTC
(
hide
)
Description:
[PASSED QA] BUG8446, QA Followup: Minor Code Tidies
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-10-10 15:09:39 UTC
Size:
1.76 KB
patch
obsolete
>From a1d9301a2d680982010785048b566957dad25158 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 23 Sep 2014 14:49:15 +0000 >Subject: [PATCH] [PASSED QA] BUG8446, QA Followup: Minor Code Tidies > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > C4/Auth.pm | 2 +- > C4/Auth_with_shibboleth.pm | 3 +-- > t/Auth_with_shibboleth.t | 1 - > 3 files changed, 2 insertions(+), 4 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index c0bd618..684faae 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -58,12 +58,12 @@ BEGIN { > $shib = C4::Context->config('useshibboleth') || 0; > $caslogout = C4::Context->preference('casLogout'); > require C4::Auth_with_cas; # no import >- require C4::Auth_with_shibboleth; > if ($ldap) { > require C4::Auth_with_ldap; > import C4::Auth_with_ldap qw(checkpw_ldap); > } > if ($shib) { >+ require C4::Auth_with_shibboleth; > import C4::Auth_with_shibboleth > qw(shib_ok checkpw_shib logout_shib login_shib_url get_login_shib); > >diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm >index ec954cd..d2a4cdf 100644 >--- a/C4/Auth_with_shibboleth.pm >+++ b/C4/Auth_with_shibboleth.pm >@@ -17,8 +17,7 @@ package C4::Auth_with_shibboleth; > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use strict; >-use warnings; >+use Modern::Perl; > > use C4::Debug; > use C4::Context; >diff --git a/t/Auth_with_shibboleth.t b/t/Auth_with_shibboleth.t >index f400989..bd627e2 100644 >--- a/t/Auth_with_shibboleth.t >+++ b/t/Auth_with_shibboleth.t >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > # >-# This Koha test module is a stub! > # Add more tests here!!! > > use Modern::Perl; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8446
:
10841
|
22098
|
22107
|
22860
|
23224
|
23225
|
23226
|
25765
|
25766
|
26176
|
26177
|
26178
|
26187
|
26749
|
26750
|
26751
|
26752
|
26760
|
26761
|
26762
|
28892
|
28893
|
28894
|
28895
|
28896
|
28897
|
28898
|
28899
|
28900
|
28901
|
28902
|
28903
|
30017
|
30018
|
30019
|
30020
|
30021
|
30022
|
30023
|
30030
|
30031
|
30033
|
30283
|
30284
|
30285
|
30286
|
30335
|
30353
|
30354
|
30355
|
30356
|
30384
|
30594
|
30604
|
30605
|
30616
|
30617
|
30618
|
30619
|
30620
|
30621
|
30684
|
31407
|
31408
|
31836
|
31905
|
31906
|
31907
|
32125
|
32158
|
32162
|
32163
|
32164
|
32165
|
32166
|
32167
|
32168
|
32169
|
32170
|
32365
|
32366
|
32367
|
32368
|
32369
|
32370
|
32371
|
32372
|
32373
|
32374
|
32426
|
32427