Bugzilla – Attachment 32185 Details for
Bug 13068
New feature for DB update and sandbox
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13068 QA follow-up
Bug-13068-QA-follow-up.patch (text/plain), 1.09 KB, created by
Paul Poulain
on 2014-10-10 18:34:48 UTC
(
hide
)
Description:
Bug 13068 QA follow-up
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2014-10-10 18:34:48 UTC
Size:
1.09 KB
patch
obsolete
>From 309d4ee9a034d4811cda74ae2976855f162ab374 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Fri, 10 Oct 2014 20:33:57 +0200 >Subject: [PATCH] Bug 13068 QA follow-up > >using the proper file handle to pass koha-qa.pl ! >--- > installer/data/mysql/updatedatabase.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 070b564..9f3acba 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -8791,8 +8791,8 @@ $/ = ';'; > while (readdir $dirh) { > next unless $_ =~ /\.sql$/; # skip non SQL files > # open and read file; >- open FILE, "<", C4::Context->config('intranetdir') . '/installer/data/mysql/db_update/'.$_ or die "ERROR, impossible to open $_"; >- while ( <FILE> ) { >+ open my $file, "<", C4::Context->config('intranetdir') . '/installer/data/mysql/db_update/'.$_ or die "ERROR, impossible to open $_"; >+ while ( <$file> ) { > my $line = $_; > $line =~ s/\n//g; > $dbh->do($line) if $line; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13068
:
32173
|
32174
|
32175
|
32177
|
32178
|
32179
|
32180
|
32185
|
32294
|
32300
|
32398
|
32399
|
32525
|
32526
|
32658
|
32659
|
32784
|
32785
|
32839
|
32840
|
32841
|
32842
|
32843
|
32919
|
32921
|
33859
|
34070
|
34071
|
34072
|
34949
|
34950
|
34951
|
34960
|
34998
|
35000
|
35001
|
35002
|
35003
|
35366
|
35367
|
35368
|
35370
|
36716
|
36717
|
36718
|
36719
|
36779
|
36780
|
36781
|
36792
|
37061
|
37062
|
37063
|
37064
|
37065
|
37066
|
37075
|
37076
|
37491