Attachment 32272 Details for Bug 12959 – Bug 12959 - Check in forgets to remember arbitrary backdating of returns setting

[patch] Bug 12959 - Check in forgets to remember arbitrary backdating of returns setting

Bug-12959---Check-in-forgets-to-remember-arbitrary.patch (text/plain), 4.47 KB, created by Jonathan Druart on 2014-10-11 20:30:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-10-11 20:30:23 UTC

Size: 4.47 KB

patch

obsolete

>From 24384146b16139b16d5a87686bd6b22c3b14f590 Mon Sep 17 00:00:00 2001
>From: ByWater Staff <staff@bywatersolutions.com>
>Date: Thu, 18 Sep 2014 10:53:35 -0400
>Subject: [PATCH] Bug 12959 - Check in forgets to remember arbitrary backdating
> of returns setting
>
>Whenever a librarian is prompted with a form during the checking process
>( hold to fill, transfer, etc ) the date to backdate returns to is forgotten!
>
>Test Plan:
>1) Begin returning items with a remembered backdate
>2) Check in an item that need transfered or has a hold
>3) Complete the action requested
>4) Note your set return date is now lost
>5) Apply this patch
>6) Repeat steps 1-3
>7) Note your backdate is now remembered!
>
>Signed-off-by: Sean McGarvey <smcgarvey@pascocountyfl.net>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 068f710..681d1b5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -162,6 +162,8 @@ $(document).ready(function () {
>             <input type="hidden" name="WT-From" value="[% wtransfertFrom %]" />
>         <input type="submit" class="approve" value="Confirm" />
>             <input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&amp;borrowernumber=[% borrowernumber %]&amp;biblionumber=[% itembiblionumber %]&amp;op=slip'); this.form.submit();" />
>+        <input type="hidden" name="return_date_override" value="[% return_date_override %]" />
>+        <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember %]" />
>     </form>
>     [% END %]</div>
> [% END %]
>@@ -209,6 +211,9 @@ $(document).ready(function () {
>                 <input type="hidden" name="diffBranch" value="[% destbranch %]" />
>                 <input type="hidden" name="exemptfine" value="[% exemptfine %]" />
>                 <input type="hidden" name="dropboxmode" value="[% dropboxmode %]" />
>+
>+                <input type="hidden" name="return_date_override" value="[% return_date_override %]" />
>+                <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember %]" />
>                 </form>
> 	</div>
>     [% END %]
>@@ -249,6 +254,9 @@ $(document).ready(function () {
>             <input type="hidden" name="exemptfine" value="[% exemptfine %]" />
>             <input type="hidden" name="dropboxmode" value="[% dropboxmode %]" />
>             <input type="hidden" name="barcode" value="0" />
>+
>+            <input type="hidden" name="return_date_override" value="[% return_date_override %]" />
>+            <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember %]" />
>         </form>
> 		</div>
>     [% END %]
>@@ -286,6 +294,8 @@ $(document).ready(function () {
> 	<input type="hidden" name="bn-[% inputloo.counter %]" value="[% inputloo.borrowernumber %]" />
> 	[% END %]
> 	<input type="hidden" name="barcode" value="0" />
>+        <input type="hidden" name="return_date_override" value="[% return_date_override %]" />
>+        <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember %]" />
> 	</form>   </div>
>     [% END %]
> 
>@@ -310,6 +320,10 @@ $(document).ready(function () {
>                     <input type="hidden" name="bn-[% inputloo.counter %]" value="[% inputloo.borrowernumber %]" />
>                 [% END %]
>             [% END %]
>+
>+            <input type="hidden" name="return_date_override" value="[% return_date_override %]" />
>+            <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember %]" />
>+
>             <input type="hidden" name="barcode" value="0" />
>         </form>
>     [% END %]
>@@ -363,6 +377,8 @@ $(document).ready(function () {
>             <input type="hidden" name="diffBranch" value="[% destbranch %]" />
>             <input type="hidden" name="exemptfine" value="[% exemptfine %]" />
>             <input type="hidden" name="dropboxmode" value="[% dropboxmode %]" />
>+            <input type="hidden" name="return_date_override" value="[% return_date_override %]" />
>+            <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember %]" />
>         </form>
> 	</div>
>     [% END %]
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 12959: 31718 | 31943 | 32272