Bugzilla – Attachment 32360 Details for
Bug 11232
Retrieve facets from Zebra
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11232: (qa followup) empty ID due to namespace mistake
PASSED-QA-Bug-11232-qa-followup-empty-ID-due-to-na.patch (text/plain), 3.21 KB, created by
Katrin Fischer
on 2014-10-15 15:32:23 UTC
(
hide
)
Description:
[PASSED QA] Bug 11232: (qa followup) empty ID due to namespace mistake
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-10-15 15:32:23 UTC
Size:
3.21 KB
patch
obsolete
>From 76a90373b1d859d7a5b51a9f5a9390b1d40706ba Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 15 Oct 2014 12:15:26 -0300 >Subject: [PATCH] [PASSED QA] Bug 11232: (qa followup) empty ID due to > namespace mistake > >Note: NORMARC is missing the id field. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >This patch makes t/db_dependent/Search.t pass again. >NORMARC is currently not tested. > >I checked the results before and after applying the patch >and the facets are now looking the same as before. >Passes all tests and QA script. >--- > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl | 2 +- > etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl | 2 +- > etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl b/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl >index 89aefee..db4c6f2 100644 >--- a/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl >+++ b/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl >@@ -28,7 +28,7 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) > </xslo:if> > </xslo:template> > <xslo:template match="marc:record"> >- <xslo:variable name="idfield" select="normalize-space()"/> >+ <xslo:variable name="idfield" select="normalize-space(marc:datafield[@tag='999']/marc:subfield[@code='c'])"/> > <z:record type="update"> > <xslo:attribute name="z:id"> > <xslo:value-of select="$idfield"/> >diff --git a/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl b/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl >index 823cdda..db6baf4 100644 >--- a/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl >+++ b/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl >@@ -28,7 +28,7 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) > </xslo:if> > </xslo:template> > <xslo:template match="marc:record"> >- <xslo:variable name="idfield" select="normalize-space()"/> >+ <xslo:variable name="idfield" select="normalize-space(marc:controlfield[@tag='001'])"/> > <z:record type="update"> > <xslo:attribute name="z:id"> > <xslo:value-of select="$idfield"/> >diff --git a/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl b/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl >index 03e635f..e970771 100644 >--- a/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl >+++ b/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl >@@ -52,7 +52,7 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) > > <xslo:template match="marc:record"> > <xslo:variable name="idfield"> >- <xsl:attribute name="select">normalize-space(<xsl:value-of select="//id"/>)</xsl:attribute> >+ <xsl:attribute name="select">normalize-space(<xsl:value-of select="//kohaidx:id"/>)</xsl:attribute> > </xslo:variable> > <z:record type="update"> > <xslo:attribute name="z:id"><xslo:value-of select="$idfield"/></xslo:attribute> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11232
:
26911
|
31426
|
31427
|
31428
|
31429
|
31430
|
31431
|
31432
|
31433
|
31434
|
31435
|
31436
|
31455
|
31456
|
31457
|
31458
|
31459
|
31460
|
31781
|
31782
|
31783
|
31784
|
31785
|
31786
|
31795
|
31796
|
31797
|
31798
|
31799
|
31800
|
32152
|
32153
|
32154
|
32155
|
32156
|
32157
|
32330
|
32331
|
32350
|
32352
|
32353
|
32354
|
32355
|
32356
|
32357
|
32358
|
32359
| 32360