Bugzilla – Attachment 32409 Details for
Bug 10126
C4::Reports::Guided is not Plack safe
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10126: (qa followup) fix tests
Bug-10126-qa-followup-fix-tests.patch (text/plain), 1005 bytes, created by
Tomás Cohen Arazi (tcohen)
on 2014-10-16 13:26:28 UTC
(
hide
)
Description:
Bug 10126: (qa followup) fix tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2014-10-16 13:26:28 UTC
Size:
1005 bytes
patch
obsolete
>From 31cff582d8b7403e45ad081d79ad8990372e0352 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Thu, 16 Oct 2014 10:24:07 -0300 >Subject: [PATCH] Bug 10126: (qa followup) fix tests > >It seems the removal of global variables changes the behaviour >of Test::MockModule, and it now expects the namespace in front >of the statically called method. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> >--- > C4/Reports/Guided.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index b782407..f793a25 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -983,7 +983,7 @@ sub IsAuthorisedValueValid { > my $reserved_authorised_values = GetReservedAuthorisedValues(); > > if ( exists $reserved_authorised_values->{$authorised_value} || >- IsAuthorisedValueCategory($authorised_value) ) { >+ C4::Koha::IsAuthorisedValueCategory($authorised_value) ) { > return 1; > } > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10126
:
32092
|
32100
|
32199
| 32409