Attachment 32473 Details for Bug 13037 – [PASSED QA] Bug 13037 - Staff client cart should exclude articles when sorting by title

[patch] [PASSED QA] Bug 13037 - Staff client cart should exclude articles when sorting by title

PASSED-QA-Bug-13037---Staff-client-cart-should-exc.patch (text/plain), 3.26 KB, created by Katrin Fischer on 2014-10-16 22:37:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-10-16 22:37:52 UTC

Size: 3.26 KB

patch

obsolete

>From 117d69e654eaff5fad28d06d3d2908a7e3b5c5b3 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 7 Oct 2014 10:01:12 -0400
>Subject: [PATCH] [PASSED QA] Bug 13037 - Staff client cart should exclude
> articles when sorting by title
>
>This patch modifies the configuration of the staff client cart table
>sorting to enable title sorting to ignore articles. Other column sorting
>configuration settings are revised to use table header classes instead
>of indexes.
>
>To test, add multiple titles to the staff client cart, choosing several
>titles which begin with articles ("a," "an," or "the" in English). View
>the cart and test sorting of all columns. Sorting by title should sort
>correctly while ignoring articles. Other columns should sort correctly
>too.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Passes tests and QA script, works as described.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt
>index 5a3d22e..a346184 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt
>@@ -62,14 +62,15 @@ function placeHold () {
> 	        return false;
> 	    });
>         $(".holdsep").text("| ");
>-        $(".hold").text(_("Place Hold"));
>+        $(".hold").text(_("Place hold"));
>         $("#downloadcartc").empty();
> 
>         $("#itemst").dataTable($.extend(true, {}, dataTablesDefaults, {
>             "sDom": 't',
>             "aoColumnDefs": [
>-                { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false },
>-                { "aTargets": [ 3 ], "sType": 'callnumbers' },
>+                { "bSortable": false, "bSearchable": false, 'aTargets': [ 'NoSort' ] },
>+                { "sType": "anti-the", "aTargets" : [ "anti-the" ] },
>+                { "sType": "callnumbers", "aTargets" : [ "callnumbers"] }
>             ],
>             "aaSorting": [[ 1, "asc" ]],
>             "bPaginate": false
>@@ -293,8 +294,8 @@ function placeHold () {
> </p>
>     <table id="itemst">
> 	<thead><tr>
>-	    [% UNLESS ( print_basket ) %]<th>&nbsp;</th>[% END %]
>-	    <th>Title</th>
>+        [% UNLESS ( print_basket ) %]<th class="NoSort">&nbsp;</th>[% END %]
>+        <th class="anti-the">Title</th>
>         <th>Item type</th>
>         <th><a id="items-popover" href="#" data-trigger="hover" data-toggle="popover" data-placement="top" title="Item sorting" data-content="Items are sorted by the highest or lowest callnumber in a group of items respectively.">Items</a></th>
>         </tr></thead>
>@@ -322,7 +323,7 @@ function placeHold () {
> 
> 						</td>
>             <td>[% BIBLIO_RESULT.description %]</td>
>-            <td>
>+            <td class="callnumbers">
>                 [% IF ( BIBLIO_RESULT.ITEM_RESULTS ) %]
>                     [% FOREACH ITEM_RESULT IN BIBLIO_RESULT.ITEM_RESULTS %]
>                         <div><span class="nowrap"><strong><span class="callnumber">[% ITEM_RESULT.itemcallnumber %]</span></strong> [% ITEM_RESULT.branchname %] <span class="shelvingloc inline">[% ITEM_RESULT.location_description %]</span></span></div>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13037: 32039 | 32319 | 32473