Bugzilla – Attachment 32508 Details for
Bug 12862
HTML fixes triggered by cleaning up language="javascript"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12862: Staff client tweaks related to obsolete language="javascript"
PASSED-QA-Bug-12862-Staff-client-tweaks-related-to.patch (text/plain), 3.13 KB, created by
Kyle M Hall (khall)
on 2014-10-17 14:41:35 UTC
(
hide
)
Description:
[PASSED QA] Bug 12862: Staff client tweaks related to obsolete language="javascript"
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-10-17 14:41:35 UTC
Size:
3.13 KB
patch
obsolete
>From 139e7fdb30ece0f8538c7c553bf134bcf1aa18b9 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 2 Sep 2014 10:13:28 -0400 >Subject: [PATCH] [PASSED QA] Bug 12862: Staff client tweaks related to obsolete language="javascript" > >As a result, this patch removed the deprecated tag from the >intranet templates. > >And since there was just 1 other tiny error in the same template >file, the checked="checked" was removed from a text box. > >TEST PLAN >--------- >1) Install the HTML Validator 0.9.5.8 for FireFox. >2) Open Intranet to Home -> Tools -> News >3) View Page Source > -- you'll notice the message about language="javascript" being > one of the error messages. >4) Click Edit beside one of the news items. >5) View Page Source > -- you'll notice the message about language="javascript" being > one of the error messages. >6) Apply patch >7) Repeat steps 2 to 5 without "language="javascript" related > error messages. >8) Run koha QA test tools. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/help/edithelp.tt | 2 +- > .../prog/en/modules/tools/koha-news.tt | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/edithelp.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/help/edithelp.tt >index 734bf0d..9ed805c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/edithelp.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/edithelp.tt >@@ -1,6 +1,6 @@ > [% INCLUDE 'doc-head-open.inc' %] > <title>Online help</title> >-<script language="javascript" type="text/javascript" src="[% interface %]/lib/tiny_mce/tiny_mce.js"></script> >+<script type="text/javascript" src="[% interface %]/lib/tiny_mce/tiny_mce.js"></script> > <script type="text/javascript">//<![CDATA[ > tinyMCE.init({ > mode : "textareas", >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >index c4a17d9..5671c7b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt >@@ -19,7 +19,7 @@ > //]]> > </script> > [% END %] >-<script language="javascript" type="text/javascript" src="[% interface %]/lib/tiny_mce/tiny_mce.js"></script> >+<script type="text/javascript" src="[% interface %]/lib/tiny_mce/tiny_mce.js"></script> > <script type="text/javascript">//<![CDATA[ > var MSG_CONFIRM_DELETE_NEWS = _("Are you sure you want to delete the selected news?"); > >@@ -138,7 +138,7 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div> > <li> > <label for="number">Appear in position: </label> > [% IF ( new_detail.number ) %] >- <input id="number" size="3" name="number" type="text" checked="checked" value="[% new_detail.number %]" /> >+ <input id="number" size="3" name="number" type="text" value="[% new_detail.number %]" /> > [% ELSE %] > <input id="number" size="3" name="number" type="text" /> > [% END %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12862
:
31325
|
31326
|
31327
|
32186
|
32187
|
32188
| 32508 |
32509
|
32510