Bugzilla – Attachment 32509 Details for
Bug 12862
HTML fixes triggered by cleaning up language="javascript"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12862: OPAC bootstrap - clean up language="javascript"
PASSED-QA-Bug-12862-OPAC-bootstrap---clean-up-lang.patch (text/plain), 2.24 KB, created by
Kyle M Hall (khall)
on 2014-10-17 14:41:42 UTC
(
hide
)
Description:
[PASSED QA] Bug 12862: OPAC bootstrap - clean up language="javascript"
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-10-17 14:41:42 UTC
Size:
2.24 KB
patch
obsolete
>From 4cc4dfe5fa71bbde3d75db029249c2c877ee5e20 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 2 Sep 2014 16:43:32 -0400 >Subject: [PATCH] [PASSED QA] Bug 12862: OPAC bootstrap - clean up language="javascript" > >There was a <script language="javascript"> tag. >It was cleaned up to be <script type="text/javascript">. >Also, the div was being chopped because the script was >in the middle of the div. Moving it to head solved the issues. > >This is difficult to test, since the printslip is triggered >when you click Finish. > >TEST PLAN >--------- > 1) Home -> Koha administration -> Global system parameters -> OPAC > 2) Set the OPAC system preference 'opacthemes' to 'bootstrap'. > 3) Start the self-checkout client (/cgi-bin/koha/sco/sco-main.pl) > 4) Log in. > 5) Check something out. > 6) Change the address url text box to > .../cgi-bin/koha/sco/printslip.pl?borrowernumber=##&print=qslip > Where ## is your borrower number which just checked something out. > 7) Click Cancel on the print dialogue > 8) View Page Source > -- The HTML validation plugin will point out multiple errors. > 9) Apply patch >10) Refresh page >11) View Page Source > -- Much happier validation results. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../bootstrap/en/modules/sco/printslip.tt | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt >index 8f02235..3cb63db 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt >@@ -6,6 +6,12 @@ > [% IF stylesheet %] > <link rel="stylesheet" type="text/css" href="[% stylesheet %]" /> > [% END %] >+<script type="text/javascript"> >+ function printThenClose() { >+ window.print(); >+ setTimeout('window.close()', 1); >+ } >+</script> > </head> > > <body id="circ_printslip" class="circ" onload="printThenClose();"> >@@ -20,11 +26,5 @@ > > </div> > >-<script language="javascript"> >- function printThenClose() { >- window.print(); >- setTimeout('window.close()', 1); >- } >-</script> > </body> > </html> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12862
:
31325
|
31326
|
31327
|
32186
|
32187
|
32188
|
32508
| 32509 |
32510