Bugzilla – Attachment 32573 Details for
Bug 13104
Changing date or time format on a production server will create duplicate fines!
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13104 - Changing date or time format on a production server will create duplicate fines!
PASSED-QA-Bug-13104---Changing-date-or-time-format.patch (text/plain), 2.70 KB, created by
Katrin Fischer
on 2014-10-21 22:49:30 UTC
(
hide
)
Description:
[PASSED QA] Bug 13104 - Changing date or time format on a production server will create duplicate fines!
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-10-21 22:49:30 UTC
Size:
2.70 KB
patch
obsolete
>From ebde25c20e14be0cc98802a987c202f651b31418 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 17 Oct 2014 08:39:19 -0400 >Subject: [PATCH] [PASSED QA] Bug 13104 - Changing date or time format on a > production server will create duplicate fines! > >The system preference TimeFormat decides if times are formatted in 24 >hour or 12 hour format. The issue at hand is that this changes the time >description for fines. Let us assume the time format is currently 24 >hour, and there are overdue items with accruing fines. When the format >is changed to 12 hour, and fines.pl is run, it will begin looking for >fines with a 12 hour format. Since there are no, it will create a new >fine and you will now have two fines for the same item! > >There are solutions which require database manipulation: >1) Update all existing fines from 24 hour to 12 hour format >2) Delete all existing accruing fines so they are all regenerated the >following night > >The same situation applies to DateFormat. > >The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does >not look for existing fines based on the description. > >I believe the best course of action until bug 6427 is pushed to master >is to add a warning to the system preference to not alter it on a >production server with existing fines. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Adds some documentation to warn about the problem. >Tested the new addition shows up in po files. >--- > .../intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >index 02985d3..dde2f09 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >@@ -7,7 +7,7 @@ I18N/L10N: > us: mm/dd/yyyy > metric: dd/mm/yyyy > iso: yyyy-mm-dd >- - . >+ - . <b>Note:</b> Do not change this preference on a production server with overdue items that are accruing fines. Doing so will result in duplicate fines! > - > - Format times in > - pref: TimeFormat >@@ -15,7 +15,7 @@ I18N/L10N: > choices: > 24hr: 24 hour format ( e.g. "14:18" ) > 12hr: 12 hour format ( e.g. "02:18 PM" ) >- - . >+ - . <b>Note:</b> Do not change this preference on a production server with overdue items that are accruing fines. Doing so will result in duplicate fines! > - > - Use > - pref: CalendarFirstDayOfWeek >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13104
:
32499
|
32519
|
32521
| 32573