Attachment 32582 Details for Bug 11926 – Bug 11926 [Follow-up] HEA - Render community koha statistic usages

[patch] Bug 11926 [Follow-up] HEA - Render community koha statistic usages

Bug-11926-Follow-up-HEA---Render-community-koha-st.patch (text/plain), 11.88 KB, created by Owen Leonard on 2014-10-22 15:34:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2014-10-22 15:34:39 UTC

Size: 11.88 KB

patch

obsolete

>From 50a87d3a21a6bd368df2da2b9bfbce57ed044454 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 22 Oct 2014 09:19:58 -0400
>Subject: [PATCH] Bug 11926 [Follow-up] HEA - Render community koha statistic
> usages
>Content-Type: text/plain; charset="utf-8"
>
>This follow-up makes some language and spelling corrections to the
>system preference descriptions. I have updated the preferences heading
>to read "Share anonymous usage statistics" in order to emphasize the
>anonymous aspect.
>
>I have also updated the main preference name from "UsageStatsShare" to
>"UsageStats" so that it is alphabetized first in the list of
>"UsageStats*" preferences. I think this will make it clearer to the Koha
>administrator what feature they are configuring.
>---
> installer/data/mysql/sysprefs.sql                  |   14 +++++-----
> installer/data/mysql/updatedatabase.pl             |   14 +++++-----
> .../intranet-tmpl/prog/en/css/preferences.css      |    2 +-
> .../prog/en/modules/admin/preferences/admin.pref   |   28 ++++++++++----------
> misc/cronjobs/share_usage_with_koha_community.pl   |   14 +++++-----
> 5 files changed, 37 insertions(+), 35 deletions(-)
>
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 5a5d5ae..600279d 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -424,13 +424,13 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('UpdateTotalIssuesOnCirc','0',NULL,'Whether to update the totalissues field in the biblio on each circ.','YesNo'),
> ('uppercasesurnames','0',NULL,'If ON, surnames are converted to upper case in patron entry form','YesNo'),
> ('URLLinkText','',NULL,'Text to display as the link anchor in the OPAC','free'),
>-('UsageStatsCountry', '', 'The country where your library is to show on hea Koha community website', NULL, 'YesNo'),
>-('UsageStatsID', '', 'This pref is part of Koha but it should not be deleted or updated manually.', '', 'Free'),
>-('UsageStatsLastUpdateTime', '', 'This pref is part of Koha but it should not be deleted or updated manually.', '', 'Free'),
>-('UsageStatsLibraryName', '', 'The library name to show on hea Koha community website', NULL, 'Free'),
>-('UsageStatsLibraryType', 'public', 'public|university', 'The library type to show on hea Koha community website', NULL, 'Choice'),
>-('UsageStatsLibraryUrl', '', 'The library url to show on hea Koha community website', NULL, 'Free'),
>-('UsageStatsShare', 0, 'Share data volumetry with Koha community (HEA).', NULL, 'YesNo'),
>+('UsageStats', 0, 'Share anonymous usage data on the Hea Koha community website.', NULL, 'YesNo'),
>+('UsageStatsCountry', '', 'The country where your library is located, to be shown on the Hea Koha community', NULL, 'YesNo'),
>+('UsageStatsID', '', 'This preference is part of Koha but it should not be deleted or updated manually.', '', 'Free'),
>+('UsageStatsLastUpdateTime', '', 'This preference is part of Koha but it should not be deleted or updated manually.', '', 'Free'),
>+('UsageStatsLibraryName', '', 'The library name to be shown on Hea Koha community website', NULL, 'Free'),
>+('UsageStatsLibraryType', 'public', 'public|university', 'The library type to be shown on the Hea Koha community website', NULL, 'Choice'),
>+('UsageStatsLibraryUrl', '', 'The library URL to be shown on Hea Koha community website', NULL, 'Free'),
> ('UseAuthoritiesForTracings','1','0','Use authority record numbers for subject tracings instead of heading strings.','YesNo'),
> ('UseBranchTransferLimits','0','','If ON, Koha will will use the rules defined in branch_transfer_limits to decide if an item transfer should be allowed.','YesNo'),
> ('UseControlNumber','0','','If ON, record control number (w subfields) and control number (001) are used for linking of bibliographic records.','YesNo'),
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index d43b2c7..4435de7 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -8826,13 +8826,13 @@ if ( CheckVersion($DBversion) ) {
>         q{
>        INSERT INTO systempreferences (variable, value, options, explanation, type )
>        VALUES
>-        ('UsageStatsCountry', '', NULL, 'The country where your library is to show on hea Koha community website', 'YesNo'),
>-        ('UsageStatsID', '', NULL, 'This pref is part of Koha but it should not be deleted or updated manually.',  'Free'),
>-        ('UsageStatsLastUpdateTime', '', NULL, 'This pref is part of Koha but it should not be deleted or updated manually.', 'Free'),
>-        ('UsageStatsLibraryName', '', NULL, 'The library name to show on hea Koha community website', 'Free'),
>-        ('UsageStatsLibraryType', 'public', 'public|university', 'The library type to show on hea Koha community website', 'Choice'),
>-        ('UsageStatsLibraryUrl', '', NULL, 'The library url to show on hea Koha community website', 'Free'),
>-        ('UsageStatsShare', 0, NULL, 'Share data volumetry with Koha community (HEA).', 'YesNo')
>+        ('UsageStatsCountry', '', NULL, 'The country where your library is located, to be shown on the Hea Koha community website', 'YesNo'),
>+        ('UsageStatsID', '', NULL, 'This preference is part of Koha but it should not be deleted or updated manually.',  'Free'),
>+        ('UsageStatsLastUpdateTime', '', NULL, 'This preference is part of Koha but it should not be deleted or updated manually.', 'Free'),
>+        ('UsageStatsLibraryName', '', NULL, 'The library name to be shown on Hea Koha community website', 'Free'),
>+        ('UsageStatsLibraryType', 'public', 'public|university', 'The library type to be shown on the Hea Koha community website', 'Choice'),
>+        ('UsageStatsLibraryUrl', '', NULL, 'The library URL to be shown on Hea Koha community website', 'Free'),
>+        ('UsageStats', 0, NULL, 'Share anonymous usage data on the Hea Koha community website.', 'YesNo')
>     });
>     print "Upgrade to $DBversion done (Bug 11926: Add UsageStats systempreferences (HEA))\n";
>     SetVersion($DBversion);
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css b/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>index c714718..7640a29 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>@@ -47,7 +47,7 @@ caption {
> h3 {
> 	color : #003366;
> 	margin : .4em 0;
>-	width : 25%;
>+    width : 40%;
> }
> 
> h3.expanded {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>index 2e566e7..98d9c1d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>@@ -105,30 +105,30 @@ Administration:
>                   yes: Allow
>                   no: "Don't Allow"
>             - Mozilla persona for login
>-    Usage Stats:
>+    Share anonymous usage statistics:
>         -
>-            - pref: UsageStatsShare
>+            - pref: UsageStats
>               default: 0
>               choices:
>                   yes: Share
>                   no: "Don't share"
>-            - data volumetry with Koha community. You can see the data on the <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>+            - anonymous Koha usage data with the Koha community. You can see the data on the <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>         -
>             - The library name
>             - pref: UsageStatsLibraryName
>-            - will be shown on <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>-            - If this name is empty, you will sent data anonymously
>-            - Note that this value has no effect if UsageStatsShare system preference is set to "Don't share"
>+            - will be shown on the <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>+            - If this field is empty data will be sent anonymously.
>+            - Note that this value has no effect if the UsageStats system preference is set to "Don't share"
>         -
>-            - The country where your library is
>+            - "The country where your library is located:"
>             - pref: UsageStatsCountry
>-            - will be shown on <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>-            - Note that this value has no effect if UsageStatsShare system preference is set to "Don't share"
>+            - This will be shown on the <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>+            - Note that this value has no effect if the UsageStats system preference is set to "Don't share"
>         -
>-            - The library url
>+            - The library URL
>             - pref: UsageStatsLibraryUrl
>-            - will be shown on <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>-            - Note that this value has no effect if UsageStatsShare system preference is set to "Don't share"
>+            - will be shown on the <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>+            - Note that this value has no effect if the UsageStats system preference is set to "Don't share"
> 
>         -
>             - The library type
>@@ -137,5 +137,5 @@ Administration:
>               choices:
>                   public: "public"
>                   university: "university"
>-            - will be shown on <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>-            - Note that this value has no effect if UsageStatsShare system preference is set to "Don't share"
>+            - will be shown on the <a href="http://hea.koha-community.org">Hea Koha community website</a>.
>+            - Note that this value has no effect if the UsageStats system preference is set to "Don't share"
>diff --git a/misc/cronjobs/share_usage_with_koha_community.pl b/misc/cronjobs/share_usage_with_koha_community.pl
>index b55edcc..b26300b 100755
>--- a/misc/cronjobs/share_usage_with_koha_community.pl
>+++ b/misc/cronjobs/share_usage_with_koha_community.pl
>@@ -20,7 +20,7 @@ if ($help) {
>     pod2usage(1);
> }
> 
>-unless ( C4::Context->preference('UsageStatsShare') ) {
>+unless ( C4::Context->preference('UsageStats') ) {
>     pod2usage(
> q|
> The UsageStats system preference is not set.
>@@ -51,19 +51,21 @@ share_usage_with_koha_community.pl - Share your library's usage with the Koha co
> 
> share_usage_with_koha_community.pl [-h|--help] [-v|--verbose]
> 
>-If the UsageStatsShare system preference is set, you can launch this script to share your usage with the Koha community.
>+If the UsageStats system preference is set, you can launch this script to share your usage data
>+anonymously with the Koha community.
> 
>-Collecting Koha usage statistics will help developpers to know how Koha is used across the world.
>+Collecting Koha usage statistics will help developers to know how Koha is used across the world.
> 
>-This script will sent the volumetry for the biblio and authority records, issues, reserves, orders and subscription.
>+This script will send the usage data for the bibliographic and authority records, checkouts, holds, orders,
>+and subscriptions.
> 
>-Only the total number is retrieved. In no case private data will be shared!
>+Only the total number is retrieved. In no case will private data be shared!
> 
> In order to know which parts of Koha modules are used, this script will collect some system preference values.
> 
> If you want to tell us who you are, you can fill the UsageStatsLibraryName system preference with your library name, UsageStatsLibraryUrl, UsageStatsLibraryType and/or UsageStatsCountry.
> 
>-All these data will be analysed on the http://hea.koha-community.org Koha community website.
>+All these data will be analyzed on the http://hea.koha-community.org Koha community website.
> 
> IMPORTANT : please do NOT run the cron on the 1st, but on another day. The idea is to avoid all
> Koha libraries sending their data at the same time ! So choose any day between 1 and 28 !
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11926: 26203 | 26346 | 26352 | 31369 | 31370 | 31373 | 32024 | 32025 | 32026 | 32027 | 32028 | 32029 | 32030 | 32262 | 32263 | 32264 | 32265 | 32266 | 32267 | 32268 | 32455 | 32456 | 32457 | 32458 | 32459 | 32460 | 32461 | 32462 | 32463 | 32464 | 32465 | 32466 | 32467 | 32468 | 32469 | 32470 | 32471 | 32472 | 32582