Attachment 32617 Details for Bug 13134 – Bug 13134 - Add patron category to returns confirmation dialogs

[patch] Bug 13134 - Add patron category to returns confirmation dialogs

Bug-13134---Add-patron-category-to-returns-confirm.patch (text/plain), 4.41 KB, created by Kyle M Hall (khall) on 2014-10-23 11:23:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-10-23 11:23:54 UTC

Size: 4.41 KB

patch

obsolete

>From 924068fb0a74465d42915cf22ceee02cf6108c36 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 14 Oct 2011 10:37:56 -0400
>Subject: [PATCH] Bug 13134 - Add patron category to returns confirmation dialogs
>
>Some librarians find it useful to know what category a patron is before
>confirming a reserve or transfer from the checkin screen.
>
>This patch adds the patron category to the hold and transfer popups
>to the patron information already displayed. The li tags that contain
>the patron category have the class "patron-category" to allow this data
>to be easily hidden.
>
>Test Plan:
>1) Apply this patch
>2) Trap a hold for a patron, note the patron category is now displayed
>3) Trap a hold for pickup at another loation, note the patron category
>   is now displayed
>---
> circ/returns.pl                                    |    3 +++
> .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    4 ++++
> 2 files changed, 7 insertions(+), 0 deletions(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 6daddc4..3c2b428 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -158,6 +158,7 @@ if ( $query->param('resbarcode') ) {
>             borcnum        => $borr->{'cardnumber'},
>             borfirstname   => $borr->{'firstname'},
>             borsurname     => $borr->{'surname'},
>+            borcategory    => $borr->{'description'},
>             diffbranch     => 1,
>         );
>     }
>@@ -381,6 +382,7 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) {
>             wname           => $name,
>             wborfirstname   => $borr->{'firstname'},
>             wborsurname     => $borr->{'surname'},
>+            wborcategory    => $borr->{'description'},
>             wbortitle       => $borr->{'title'},
>             wborphone       => $borr->{'phone'},
>             wboremail       => $borr->{'email'},
>@@ -424,6 +426,7 @@ if ( $messages->{'ResFound'}) {
>             name           => $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'},
>             borfirstname   => $borr->{'firstname'},
>             borsurname     => $borr->{'surname'},
>+            borcategory    => $borr->{'description'},
>             bortitle       => $borr->{'title'},
>             borphone       => $borr->{'phone'},
>             boremail       => $borr->{'email'},
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 4daf601..73c04bd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -148,6 +148,7 @@ $(document).ready(function () {
> [% IF ( wborcnum ) %]<h5>Hold for:</h5>
>         <ul><li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">
>             [% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li>
>+        <li class="patron-category">[% wborcategory %]</li>
>         <li>[% wboraddress %][% IF ( wboraddress2 ) %]<br />
> 		[% wboraddress2 %]<br />[% END %]
>         [% wborcity %]  [% wborzip %]</li>
>@@ -181,6 +182,7 @@ $(document).ready(function () {
>         <h4>Hold for:</h4>
> 			<ul>
>             <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li>
>+            <li class="patron-category">[% borcategory %]</li>
>             <li>[% boraddress %]<br />
> 			[% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %]
>             [% borcity %] [% borzip %]</li>
>@@ -222,6 +224,7 @@ $(document).ready(function () {
>                 <h4>Hold for: </h4>
>                     <ul>
>                         <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li>
>+                        <li class="patron-category">[% borcategory %]</li>
>                         <li>[% boraddress %]<br />
> 						[% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %]
> 						[% borcity %]  [% borzip %]</li>
>@@ -330,6 +333,7 @@ $(document).ready(function () {
>             <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">
>                 [% borsurname %], [% borfirstname %]
>             </a> ([% borcnum %])</li>
>+            <li class="patron-category">[% borcategory %]</li>
>             <li>[% boraddress %]<br />
> 			[% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %]
> 			[% borcity %] [% borzip %]</li>
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13134: 32617 | 32618 | 32642 | 54282 | 54306 | 54307 | 54358 | 54359