Bugzilla – Attachment 32630 Details for
Bug 12995
script update_totalissues.pl stops on corrupted record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12995 - script update_totalissues.pl stops on corrupted record - UT
SIGNED-OFF-Bug-12995---script-updatetotalissuespl-.patch (text/plain), 1.26 KB, created by
Owen Leonard
on 2014-10-23 15:41:54 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12995 - script update_totalissues.pl stops on corrupted record - UT
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-10-23 15:41:54 UTC
Size:
1.26 KB
patch
obsolete
>From 77cc786218020ecfb740883e7810b2811d1c319a Mon Sep 17 00:00:00 2001 >From: Admin User Koha <koha@localhost> >Date: Mon, 20 Oct 2014 15:05:23 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 12995 - script update_totalissues.pl stops > on corrupted record - UT >Content-Type: text/plain; charset="utf-8" > >This patch adds an unit test on C4::Biblio::UpdateTotalIssues method >call on non existing record > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >I can't comment on the correctness of the test other than to say it ran >successfully. >--- > t/Biblio.t | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/t/Biblio.t b/t/Biblio.t >index 8662c40..67f752d 100755 >--- a/t/Biblio.t >+++ b/t/Biblio.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 42; >+use Test::More tests => 44; > use Test::Warn; > > BEGIN { >@@ -155,4 +155,10 @@ warning_is { $ret = RemoveAllNsb() } > > ok( !defined $ret, 'RemoveAllNsb returns undef if not passed rec'); > >+warning_is { $ret = UpdateTotalIssues() } >+ { carped => 'UpdateTotalIssues could not get biblio record'}, >+ "UpdateTotalIssues returns carped warning if biblio record does not exist"; >+ >+ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist'); >+ > 1; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12995
:
31875
|
32454
|
32534
|
32535
|
32536
|
32629
|
32630
|
32654
|
32695
|
32696