Attachment 32640 Details for Bug 13095 – Bug 13095: An email will be sent shortly

[patch] Bug 13095: An email will be sent shortly

Bug-13095-An-email-will-be-sent-shortly.patch (text/plain), 3.08 KB, created by Chris Cormack on 2014-10-23 18:36:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2014-10-23 18:36:27 UTC

Size: 3.08 KB

patch

obsolete

>From d36bd8f6aa681b28ab0fe230eadc63ea52ad0845 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 16 Oct 2014 13:48:36 +0200
>Subject: [PATCH] Bug 13095: An email will be sent shortly
>
>This patch adjusts two instances where Koha says that an email has
>been sent while it is just enqueued (put in the message queue). The
>crontab example still suggests to run process_message_queue once an hour
>and the manual even speaks about 1-4 hours.
>
>In the process of selfregistration and sharing a shelf, I have adjusted
>the text "has been sent" to "will be sent shortly". This covers imo
>the one-hour frequency.
>
>When writing this patch, I have examined all calls of EnqueueLetter;
>I only found these two occurrences to be of interest.
>
>Note: I would recommend to increase this frequency in the documentation,
>but consider that for now to be outside the scope of this report.
>
>Test plan:
>[1] Self-register a new user with verification by email required. Look at
>    the text when you submit your data.
>[2] Share a list with someone else. Look at the text when you submit the
>    invitation.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> .../opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt      | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt             | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt
>index 1900acc..2fac057 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-email-sent.tt
>@@ -29,7 +29,7 @@
>                         <div id="confirmation-pending" class="alert alert-info">
>                             <h1>Please confirm your registration</h1>
> 
>-                            <p>A confirmation email has been sent to the email address <strong>[% email %]</strong>.</p>
>+                            <p>A confirmation email will be sent shortly to the email address <strong>[% email %]</strong>.</p>
> 
>                             <p>Your account will not be activated until you follow the link provided in the confirmation email.</p>
>                         </div>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
>index 05a305b..6891891 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
>@@ -66,7 +66,7 @@
>     [% ELSIF op=='conf_invite' %]
>         <div id="conf_invite">
>         [% IF approvedaddress %]
>-        <p>An invitation to share list <i>[% shelfname %]</i> has been sent to [% approvedaddress %].</p>
>+        <p>An invitation to share list <i>[% shelfname %]</i> will be sent shortly to [% approvedaddress %].</p>
>         [% END %]
>         [% IF failaddress %]
>             <p>Something went wrong while processing the following addresses. Please check them. These are: [% failaddress %]</p>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13095: 32402 | 32640 | 32647