Bugzilla – Attachment 32642 Details for
Bug 13134
Add patron category to returns confirmation dialogs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13134 - Add patron category to returns confirmation dialogs
Bug-13134---Add-patron-category-to-returns-confirm.patch (text/plain), 5.80 KB, created by
Kyle M Hall (khall)
on 2014-10-23 18:41:45 UTC
(
hide
)
Description:
Bug 13134 - Add patron category to returns confirmation dialogs
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-10-23 18:41:45 UTC
Size:
5.80 KB
patch
obsolete
>From 07454d2bb4f4ba3d3c33173c3584b29ed802b156 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 14 Oct 2011 10:37:56 -0400 >Subject: [PATCH] Bug 13134 - Add patron category to returns confirmation dialogs > >Some librarians find it useful to know what category a patron is before >confirming a reserve or transfer from the checkin screen. > >This patch adds the patron category to the hold and transfer popups >to the patron information already displayed. The li tags that contain >the patron category have the class "patron-category" to allow this data >to be easily hidden. > >Test Plan: >1) Apply this patch >2) Trap a hold for a patron, note the patron category is now displayed >3) Trap a hold for pickup at another loation, note the patron category > is now displayed >--- > circ/returns.pl | 3 +++ > .../intranet-tmpl/prog/en/modules/circ/returns.tt | 10 +++++----- > 2 files changed, 8 insertions(+), 5 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index d99f58c..0704384 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -158,6 +158,7 @@ if ( $query->param('resbarcode') ) { > borcnum => $borr->{'cardnumber'}, > borfirstname => $borr->{'firstname'}, > borsurname => $borr->{'surname'}, >+ borcategory => $borr->{'description'}, > diffbranch => 1, > ); > } >@@ -381,6 +382,7 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) { > wname => $name, > wborfirstname => $borr->{'firstname'}, > wborsurname => $borr->{'surname'}, >+ wborcategory => $borr->{'description'}, > wbortitle => $borr->{'title'}, > wborphone => $borr->{'phone'}, > wboremail => $borr->{'email'}, >@@ -425,6 +427,7 @@ if ( $messages->{'ResFound'}) { > name => $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'}, > borfirstname => $borr->{'firstname'}, > borsurname => $borr->{'surname'}, >+ borcategory => $borr->{'description'}, > bortitle => $borr->{'title'}, > borphone => $borr->{'phone'}, > boremail => $borr->{'email'}, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 068f710..3512ff6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -148,8 +148,8 @@ $(document).ready(function () { > [% IF ( WrongTransfer ) %]<div id="return2" class="dialog message"><!-- WrongTransfer --><h3>Please return <a href="/cgi-bin/koha/catalogue/detail.pl?type=intra&biblionumber=[% itembiblionumber %]">[% title |html %]</a> to [% Branches.GetName( TransferWaitingAt ) %]</h3><h3><a href="#" onclick="Dopop('transfer-slip.pl?transferitem=[% itemnumber %]&&branchcode=[% homebranch %]&op=slip'); return true;">Print slip</a> or <a href="/cgi-bin/koha/circ/returns.pl?itemnumber=[% itemnumber %]&canceltransfer=1">Cancel transfer</a></h3> > [% IF ( wborcnum ) %]<h5>Hold for:</h5> > <ul><li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]"> >- [% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li> >- <li>[% wborstnum %] [% wboraddress %][% IF ( wboraddress2 ) %]<br /> >+ [% borsurname %], [% borfirstname %]</a> ([% borcnum %]) <span class="patron-category"> - [% wborcategory %]</span> </li> >+ <li>[% wborstnum %] [% wboraddress %][% IF ( wboraddress2 ) %]<br /> > [% wboraddress2 %]<br />[% END %] > [% wborcity %] [% wborzip %]</li> > [% IF ( wborphone ) %]<li>[% wborphone %]</li>[% END %] >@@ -181,7 +181,7 @@ $(document).ready(function () { > [% IF ( reservenotes ) %]<h4>Notes: [% reservenotes %]</h4>[% END %] > <h4>Hold for:</h4> > <ul> >- <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li> >+ <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %]) <span class="patron-category"> - [% wborcategory %]</span> </li> > <li>[% borstnum %] [% boraddress %]<br /> > [% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %] > [% borcity %] [% borzip %]</li> >@@ -222,7 +222,7 @@ $(document).ready(function () { > <h3>Hold needing transfer found: <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% itembiblionumber %]">[% title |html %]</a></h3> > <h4>Hold for: </h4> > <ul> >- <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %])</li> >+ <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %]) <span class="patron-category"> - [% wborcategory %]</span> </li> > <li>[% borstnum %] [% boraddress %]<br /> > [% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %] > [% borcity %] [% borzip %]</li> >@@ -330,7 +330,7 @@ $(document).ready(function () { > <ul> > <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]"> > [% borsurname %], [% borfirstname %] >- </a> ([% borcnum %])</li> >+ </a> ([% borcnum %]) <span class="patron-category"> - [% wborcategory %]</span></li> > <li>[% borstnum %] [% boraddress %]<br /> > [% IF ( boraddress2 ) %][% boraddress2 %]<br />[% END %] > [% borcity %] [% borzip %]</li> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13134
:
32617
|
32618
|
32642
|
54282
|
54306
|
54307
|
54358
|
54359