Bugzilla – Attachment 32645 Details for
Bug 13028
Remove uninitialized value warning and add partial flag to cmp_sysprefs script
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194
PASSED-QA-Bug-13028-Resolve-uninitialized-value-in.patch (text/plain), 1.64 KB, created by
Katrin Fischer
on 2014-10-23 21:56:30 UTC
(
hide
)
Description:
[PASSED QA] Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-10-23 21:56:30 UTC
Size:
1.64 KB
patch
obsolete
>From 8567a9d8f0b571244c35554231d8455b6b2663ed Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 6 Oct 2014 14:09:53 +0200 >Subject: [PATCH] [PASSED QA] Bug 13028: Resolve uninitialized value in string > eq at cmp_sysprefs.pl line 194 > >If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high. > >This is corrected by a better test of the hash value in the CheckVersionPref subroutine. > >Test plan: >[1] Create a small pref file and remove the version pref (if present). You >could for instance do a pref backup and remove most lines. >[2] Use the restore option with and without this patch. > So, something like: > maintclone/misc/maintenance/cmp_sysprefs.pl -c r -f 9999crucial.pref >[3] Check on the error message and the pref count. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > misc/maintenance/cmp_sysprefs.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/maintenance/cmp_sysprefs.pl b/misc/maintenance/cmp_sysprefs.pl >index c688466..bed32a2 100755 >--- a/misc/maintenance/cmp_sysprefs.pl >+++ b/misc/maintenance/cmp_sysprefs.pl >@@ -234,7 +234,7 @@ sub DeleteOnePref { > sub CheckVersionPref { #additional precaution > #if there are versions, compare them > my ($hash) = @_; >- my $hv = $hash->{version}->{value}; >+ my $hv = exists $hash->{version}? $hash->{version}->{value}: undef; > return if !defined $hv; > my ($dv) = $dbh->selectrow_array( > 'SELECT value FROM systempreferences >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13028
:
32005
|
32062
|
32641
|
32643
| 32645 |
32646