Bugzilla – Attachment 32655 Details for
Bug 13123
Duplicate label ids for language and opaclanguages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13123 - Duplicate label ids for language and opaclanguages
PASSED-QA-Bug-13123---Duplicate-label-ids-for-lang.patch (text/plain), 4.87 KB, created by
Katrin Fischer
on 2014-10-24 06:29:14 UTC
(
hide
)
Description:
[PASSED QA] Bug 13123 - Duplicate label ids for language and opaclanguages
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-10-24 06:29:14 UTC
Size:
4.87 KB
patch
obsolete
>From 829f24b5e65757e5fa9619444e1f9f9b880caa5d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 21 Oct 2014 14:31:25 -0400 >Subject: [PATCH] [PASSED QA] Bug 13123 - Duplicate label ids for language and > opaclanguages > >When enabling or disabling a OPAC language choice clicking the label >triggers the checkbox under the language preference instead. This is >because both <label>s have the same id. > >This patch adds a modifier to each label and corresponding id attribute >in order to make them unique. > >To test, go to Administration -> System preferences -> I18N/L10N. >Clicking the "English (en)" label under the "language" system preference >should toggle the corresponding checkbox. Clicking the "English (en)" >label under the "opaclanguages" system preference should toggle the >correct checkbox. > >Further tests: > >- Install an English 'sub-language' like en-GB and confirm that > checkbox labels work correctly. >- Install a non-English language and confirm that checkbox labels work > correctly. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described, template changes only. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index 6b77990..2f0daab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -128,21 +128,21 @@ > </dt> > [% FOREACH sublanguages_loo IN language.sublanguages_loop %] > <dd> >- <label for="[% sublanguages_loo.rfc4646_subtag %]">[% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]([% sublanguages_loo.rfc4646_subtag %])</label> >+ <label for="pref_[% CHUNK.name %]_[% sublanguages_loo.rfc4646_subtag %]">[% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]([% sublanguages_loo.rfc4646_subtag %])</label> > [% IF ( sublanguages_loo.enabled ) %] >- <input value="[% sublanguages_loo.rfc4646_subtag %]" name="pref_[% CHUNK.name %]" id="[% sublanguages_loo.rfc4646_subtag %]" type="checkbox" checked="checked" class="preference preference-checkbox"/> >+ <input value="[% sublanguages_loo.rfc4646_subtag %]" name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]_[% sublanguages_loo.rfc4646_subtag %]" type="checkbox" checked="checked" class="preference preference-checkbox"/> > [% ELSE %] >- <input value="[% sublanguages_loo.rfc4646_subtag %]" name="pref_[% CHUNK.name %]" id="[% sublanguages_loo.rfc4646_subtag %]" type="checkbox" class="preference preference-checkbox"/> >+ <input value="[% sublanguages_loo.rfc4646_subtag %]" name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]_[% sublanguages_loo.rfc4646_subtag %]" type="checkbox" class="preference preference-checkbox"/> > [% END %] > </dd> > [% END %] > [% ELSE %] > <dt> >- <label for="[% language.rfc4646_subtag %]">[% language.native_description %]([% language.rfc4646_subtag %])</label> >+ <label for="pref_[% CHUNK.name %]_[% language.rfc4646_subtag %]">[% language.native_description %]([% language.rfc4646_subtag %])</label> > [% IF ( language.group_enabled ) %] >- <input value="[% language.rfc4646_subtag %]" name="pref_[% CHUNK.name %]" id="[% language.rfc4646_subtag %]" type="checkbox" checked="checked" class="preference preference-checkbox"/> >+ <input value="[% language.rfc4646_subtag %]" name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]_[% language.rfc4646_subtag %]" type="checkbox" checked="checked" class="preference preference-checkbox"/> > [% ELSE %] >- <input value="[% language.rfc4646_subtag %]" name="pref_[% CHUNK.name %]" id="[% language.rfc4646_subtag %]" type="checkbox" class="preference preference-checkbox"/> >+ <input value="[% language.rfc4646_subtag %]" name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]_[% language.rfc4646_subtag %]" type="checkbox" class="preference preference-checkbox"/> > [% END %] > </dt> > [% END %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13123
:
32562
|
32613
| 32655