Bugzilla – Attachment 32668 Details for
Bug 13088
Allow the user to specify a max amount of facets to show.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 13088: Allow the user to specify a max amount of facets to show
SIGNED-OFF-Bug-13088-Allow-the-user-to-specify-a-m.patch (text/plain), 1.84 KB, created by
Owen Leonard
on 2014-10-24 13:53:31 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 13088: Allow the user to specify a max amount of facets to show
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-10-24 13:53:31 UTC
Size:
1.84 KB
patch
obsolete
>From 746bd773decdc1d146122a0485a7ebb689401176 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Mon, 20 Oct 2014 12:12:00 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 13088: Allow the user to specify a max > amount of facets to show >Content-Type: text/plain; charset="utf-8" > >This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) >to set the max facets to show for each facet category. It defaults to 20 if >the syspref is absent or empty. > >To test: >- Have a search with lots of facet results (with some category showing the "See more" link). >- Jump to "See more", notice it shows more than 20 facet values. >- Apply the patch, reload the page. >=> SUCCESS It only shows 20 (default hardcoded value) >- Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). >- Reload >=> SUCCESS: it shows the expected amount. >- Sign off :-D > >Regards > >Sponsored-by: Universidad Nacional de Cordoba >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Test plan completed successfully >--- > C4/Search.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index d46b0c5..9995ea3 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -788,11 +788,12 @@ sub _get_facet_from_result_set { > my $rs = shift; > my $sep = shift; > >- my $internal_sep = '<*>'; >+ my $internal_sep = '<*>'; >+ my $facetMaxCount = C4::Context->preference('FacetMaxCount') // 20; > > return if ( ! defined $facet_idx || ! defined $rs ); > # zebra's facet element, untokenized index >- my $facet_element = 'zebra::facet::' . $facet_idx . ':0:100'; >+ my $facet_element = 'zebra::facet::' . $facet_idx . ':0:' . $facetMaxCount; > # configure zebra results for retrieving the desired facet > $rs->option( elementSetName => $facet_element ); > # get the facet record from result set >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13088
:
32553
|
32554
|
32667
|
32668
|
32738
|
32739
|
32844