Attachment 32688 Details for Bug 13141 – Bug 13141 [QA Followup] - Update number of unit tests

[patch] Bug 13141 [QA Followup] - Update number of unit tests

Bug-13141-QA-Followup---Update-number-of-unit-test.patch (text/plain), 1.48 KB, created by Mark Tompsett on 2014-10-24 18:20:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-10-24 18:20:39 UTC

Size: 1.48 KB

patch

obsolete

>From 3dcbe93b8dedb9bb854c834683763bf28e61cd06 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 24 Oct 2014 09:42:37 -0400
>Subject: [PATCH] Bug 13141 [QA Followup] - Update number of unit tests
>
>While updating the number of unit tests from 12 to 13,
>the number of tests to skip due to a outdated version
>of DBD::Mock was missed.
>
>This patch retains the test number change, and corrects
>the number of tests.
>
>TEST PLAN
>---------
>1) prove -v t/db_dependent/ReportsGuided.t
>   -- on an UBUNTU git (lacks DBD::Mock >= 1.45)
>2) prove -v t/db_dependent/ReportsGuided.t
>   -- on a DEBIAN git (has DBD::Mock >= 1.45)
>3) compare results.
>   -- skipped tests should be 8 (2 individual tests + 6 in the loop)
>      under Ubuntu.
>   -- non-skipped tests should align.
>   -- everything should be 13 tests.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/ReportsGuided.t |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/ReportsGuided.t b/t/db_dependent/ReportsGuided.t
>index e111617..d51ca8d 100755
>--- a/t/db_dependent/ReportsGuided.t
>+++ b/t/db_dependent/ReportsGuided.t
>@@ -2,7 +2,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 12;
>+use Test::More tests => 13;
> use Test::MockModule;
> use DBD::Mock;
> 
>@@ -55,7 +55,7 @@ $koha->mock(
> 
> SKIP: {
> 
>-    skip "DBD::Mock is too old", 7
>+    skip "DBD::Mock is too old", 8
>         unless $DBD::Mock::VERSION >= 1.45;
> 
>     ok( IsAuthorisedValueValid('LOC'),
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 13141: 32650 | 32664 | 32677 | 32678 | 32688 | 32960 | 32961 | 33003 | 33004