Attachment 32697 Details for Bug 12590 – Bug 12590 - Support deletion of biblio in svc API

[patch] Bug 12590 - Support deletion of biblio in svc API

Bug-12590---Support-deletion-of-biblio-in-svc-API.patch (text/plain), 2.41 KB, created by Chris Cormack on 2014-10-25 03:06:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2014-10-25 03:06:56 UTC

Size: 2.41 KB

patch

obsolete

>From 6f071245496835e9007d4ba75a2d98f6fabbd82c Mon Sep 17 00:00:00 2001
>From: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com>
>Date: Thu, 17 Jul 2014 10:55:20 +0200
>Subject: [PATCH] Bug 12590 - Support deletion of biblio in svc API
>
>The /svc endpoint allows you to create and update biblio records.
>This patch extends it so that it is also possible to delete a biblio.
>
>Test plan
>* Create a new biblio by sending a POST request to /svc/new_bib with a
>  marcxml record as request body. Note the biblionumber it gets assigned.
>* Make some changes to the marcxml record, and update it by sending
>  a POST request to /svc/bib/{bibilonumber}
>* Observe that the changes are persisted on the biblio record.
>* Now delete the bilblio by sending a DELETE request to
>  /svc/bib/{biblionumber}
>* Observe that the biblio is indeed gone from the db.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> svc/bib | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
>diff --git a/svc/bib b/svc/bib
>index 8f6a168..d7cd169 100755
>--- a/svc/bib
>+++ b/svc/bib
>@@ -48,11 +48,17 @@ if ($path_info =~ m!^/(\d+)$!) {
>     print $query->header(-type => 'text/xml', -status => '400 Bad Request');
> }
> 
>-# are we retrieving or updating a bib?
>+# are we retrieving, updating or deleting a bib?
> if ($query->request_method eq "GET") {
>     fetch_bib($query, $biblionumber);
>-} else {
>+} elsif ($query->request_method eq "POST") {
>     update_bib($query, $biblionumber);
>+} elsif ($query->request_method eq "DELETE") {
>+    delete_bib($query, $biblionumber);
>+} else {
>+    print $query->header(-type => 'text/xml', -status => '405 Method not allowed');
>+    print XMLout({ error => 'Method not allowed' }, NoAttr => 1, RootName => 'response', XMLDecl => 1);
>+    exit 0;
> }
> 
> exit 0;
>@@ -120,3 +126,18 @@ sub update_bib {
>    
>     print XMLout($result, NoAttr => 1, RootName => 'response', XMLDecl => 1, NoEscape => $do_not_escape); 
> }
>+
>+sub delete_bib {
>+    my $query = shift;
>+    my $biblionumber = shift;
>+    my $error = DelBiblio($biblionumber);
>+
>+    if (defined $error) {
>+        print $query->header(-type => 'text/xml', -status => '400 Bad request');
>+        print XMLout({ error => $error }, NoAttr => 1, RootName => 'response', XMLDecl => 1);
>+        exit 0;
>+    }
>+
>+    print $query->header(-type => 'text/xml');
>+    print XMLout({ status => 'OK, biblio deleted' }, NoAttr => 1, RootName => 'response', XMLDecl => 1);
>+}
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12590: 29786 | 32697 | 32736