Attachment 32706 Details for Bug 13140 – Bug 13140: Add a notice on the About page about GRS-1 deprecated

[patch] Bug 13140: Add a notice on the About page about GRS-1 deprecated

Bug-13140-Add-a-notice-on-the-About-page-about-GRS.patch (text/plain), 5.19 KB, created by Frédéric Demians on 2014-10-25 09:38:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Demians

Created: 2014-10-25 09:38:53 UTC

Size: 5.19 KB

patch

obsolete

>From 93d1f12a1c63f5b911634c54f69c98f60b00ff3c Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Thu, 23 Oct 2014 21:32:30 -0300
>Subject: [PATCH] Bug 13140: Add a notice on the About page about GRS-1
> deprecated
>
>This patch changes the text for zebra_auth_index_mode and zebra_bib_index_mode
>entries missing on koha-conf.xml telling the user GRS-1 is deprecated.
>
>It also adds another check for those preferences set to GRS-1, and shows a
>warning message if set to grs1.
>
>To test:
>- Apply the patch and try all combinations:
>- zebra_auth_index_mode and zebra_bib_index_mode missing
>- zebra_auth_index_mode and zebra_bib_index_mode set to grs1
>- Sign off :-D
>
>Regards
>
>Signed-off-by: Frederic Demians <f.demians@tamil.fr>
>
>I've played with the 3 related koha-conf.xml file parameters:
>zebra_auth_index_moda, zebra_bib_index_mode missing, and use_zebra_facets.
>Inconsitencies are properly reported in About page thanks to this patch. It
>would be helpfull to admin upgrading their Koha installation.
>
>And by the way, thanks Tomas for the new Zebra facets functionnality. It's a
>'joy' to see it into Koha.
>---
> about.pl | 6 +++++
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 34 ++++++++++++++++++++++--
> 2 files changed, 38 insertions(+), 2 deletions(-)
>
>diff --git a/about.pl b/about.pl
>index 339f4e2..4fbc7e8 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -84,12 +84,18 @@ if ( ! defined C4::Context->config('zebra_bib_index_mode') ) {
> push @xml_config_warnings, {
> error => 'zebra_bib_index_mode_warn'
> };
>+} else {
>+ push @xml_config_warnings, { error => 'zebra_bib_grs_warn' }
>+ if C4::Context->config('zebra_bib_index_mode') eq 'grs1';
> }
> 
> if ( ! defined C4::Context->config('zebra_auth_index_mode') ) {
> push @xml_config_warnings, {
> error => 'zebra_auth_index_mode_warn'
> };
>+} else {
>+ push @xml_config_warnings, { error => 'zebra_auth_grs_warn' }
>+ if C4::Context->config('zebra_auth_index_mode') eq 'grs1';
> }
> 
> # Test QueryParser configuration sanity
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index 75a367d..6e87b37 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -145,9 +145,39 @@
> <caption>XML configuration file</caption>
> [% FOREACH config_entry IN xml_config_warnings %]
> [% IF config_entry.error == 'zebra_bib_index_mode_warn' %]
>- <tr><th scope="row">Warning </th><td>The &lt;zebra_bib_index_mode&gt; entry is missing in your configuration file. It should be set to dom or grs1. It will default to grs1 but this could change in the future.</td></tr>
>+ <tr>
>+ <th scope="row">Warning</th>
>+ <td>The &lt;zebra_bib_index_mode&gt; entry is missing in your configuration file.
>+ It should be set to dom or grs1 (deprecated).
>+ It will default to dom.
>+ </td>
>+ </tr>
> [% ELSIF config_entry.error == 'zebra_auth_index_mode_warn' %]
>- <tr><th scope="row">Warning </th><td>The &lt;zebra_auth_index_mode&gt; entry is missing in your configuration file. It should be set to dom or grs1. It will default to dom but this could change in the future.</td></tr>
>+ <tr>
>+ <th scope="row">Warning</th>
>+ <td>The &lt;zebra_auth_index_mode&gt; entry is missing in your configuration file.
>+ It should be set to dom or grs1 (deprecated).
>+ It will default to dom.
>+ </td>
>+ </tr>
>+ [% ELSIF config_entry.error == 'zebra_bib_grs_warn' %]
>+ <tr>
>+ <th scope="row">Warning</th>
>+ <td>The &lt;zebra_bib_index_mode&gt; entry is set to grs1.
>+ GRS-1 support is now deprecated and will be removed in future releases.
>+ Please use DOM instead by setting &lt;zebra_bib_index_mode&gt; to
>+ dom (full reindex required).
>+ </td>
>+ </tr>
>+ [% ELSIF config_entry.error == 'zebra_auth_grs_warn' %]
>+ <tr>
>+ <th scope="row">Warning</th>
>+ <td>The &lt;zebra_auth_index_mode&gt; entry is set to grs1.
>+ GRS-1 support is now deprecated and will be removed in future releases.
>+ Please use DOM instead by setting &lt;zebra_auth_index_mode&gt; to
>+ dom (full reindex required).
>+ </td>
>+ </tr>
> [% ELSIF config_entry.error == 'queryparser_entry_missing' %]
> <tr>
> <th scope="row">Warning</th>
>-- 
>2.1.2

Actions: View | Diff | Splinter Review

Attachments on bug 13140: 32649 | 32706 | 32717