Attachment 32710 Details for Bug 13120 – Bug 13120 - Invalid HTML generated by MARC21slim2OPACResults.xsl

[patch] Bug 13120 - Invalid HTML generated by MARC21slim2OPACResults.xsl

Bug-13120---Invalid-HTML-generated-by-MARC21slim2O.patch (text/plain), 1.79 KB, created by Frédéric Demians on 2014-10-25 10:04:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Demians

Created: 2014-10-25 10:04:18 UTC

Size: 1.79 KB

patch

obsolete

>From 3b95eef34aada3a3aeeecaa38992725dfa80add3 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 21 Oct 2014 14:05:31 -0400
>Subject: [PATCH] Bug 13120 - Invalid HTML generated by
> MARC21slim2OPACResults.xsl
>
>This patch converts an id to a class in order to avoid duplicate id
>attributes on one page.
>
>To test you must have XSLT enabled with the default setting. Perform a
>search in the OPAC and confirm that the display of location looks
>correct.
>
>Run the resulting page through a validator using an in-browser tool like
>Firefox's Html Validator addon or using the W3C's validator.w3.org. The
>results should not complain of duplicate id attributes.
>
>Signed-off-by: Frederic Demians <f.demians@tamil.fr>
>
>OK for me. Obvious mistake: I can confirm FF HTML validator reports it, and
>stop reporting it after applying this patch.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>index d83f3c2..e5405b8 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>@@ -1188,7 +1188,7 @@
> 
> <xsl:choose>
> <xsl:when test="($OPACItemLocation='location' or $OPACItemLocation='ccode') and (count(key('item-by-status', 'available'))!=0 or count(key('item-by-status', 'reference'))!=0)">
>- 
>+ 
> Location(s): 
> <xsl:choose>
> <xsl:when test="count(key('item-by-status', 'available'))>0">
>-- 
>2.1.2

Actions: View | Diff | Splinter Review

Attachments on bug 13120: 32560 | 32710 | 32714