Bugzilla – Attachment 3294 Details for
Bug 5865
Labels wrap incorrectly when paper width is greater than height
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed-off patch
bug_5865.patch (text/plain), 1.53 KB, created by
Jared Camins-Esakov
on 2011-03-14 20:29:27 UTC
(
hide
)
Description:
Signed-off patch
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2011-03-14 20:29:27 UTC
Size:
1.53 KB
patch
obsolete
>From 4ad3c0fbd0457d90a6384b40dfdc4f3473eb136c Mon Sep 17 00:00:00 2001 >From: Chris Nighswonger <cnighswonger@foundations.edu> >Date: Mon, 14 Mar 2011 15:35:42 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 5865 - Labels wrap incorrectly when paper width is greater than height >Content-Type: text/plain; charset="utf-8" > >This is due to the incorrect use of string comparators to compare numeric values. >This patch corrects that. > >Note: This should be backported to 3.2.x > >Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com> >--- > labels/label-create-pdf.pl | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/labels/label-create-pdf.pl b/labels/label-create-pdf.pl >index 1108726..608be04 100755 >--- a/labels/label-create-pdf.pl >+++ b/labels/label-create-pdf.pl >@@ -33,13 +33,13 @@ my $layout = C4::Labels::Layout->retrieve(layout_id => $layout_id); > > sub _calc_next_label_pos { > my ($row_count, $col_count, $llx, $lly) = @_; >- if ($col_count lt $template->get_attr('cols')) { >+ if ($col_count < $template->get_attr('cols')) { > $llx = ($llx + $template->get_attr('label_width') + $template->get_attr('col_gap')); > $col_count++; > } > else { > $llx = $template->get_attr('left_margin'); >- if ($row_count eq $template->get_attr('rows')) { >+ if ($row_count == $template->get_attr('rows')) { > $pdf->Page(); > $lly = ($template->get_attr('page_height') - $template->get_attr('top_margin') - $template->get_attr('label_height')); > $row_count = 1; >-- >1.7.2.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5865
:
3293
| 3294