Bugzilla – Attachment 32989 Details for
Bug 12334
Make it easier to hide parts of material type and format information in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12334: Make it easy to hide parts of material type and format information in results
Bug-12334-Make-it-easy-to-hide-parts-of-material-t.patch (text/plain), 13.44 KB, created by
Brendan Gallagher
on 2014-10-30 16:48:46 UTC
(
hide
)
Description:
Bug 12334: Make it easy to hide parts of material type and format information in results
Filename:
MIME Type:
Creator:
Brendan Gallagher
Created:
2014-10-30 16:48:46 UTC
Size:
13.44 KB
patch
obsolete
>From 10b56d5f3d5d190bf938a7f48e1875fd3b685002 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Thu, 28 Aug 2014 13:32:35 +0200 >Subject: [PATCH] Bug 12334: Make it easy to hide parts of material type and > format information in results > >With the system preferences DisplayIconsXSLT and DisplayOPACiconsXSLT we control >the visibility of the material type, format and audience information in staff >and OPAC. > >Sometimes a library might only want to hide a part of that information - for >example, hide audience but keep the material type icon. > >This patch adds CSS classes to make it easier to style this section of the page >and hide parts of the information. > >To test: >- Verify that OPAC and staff result lists for various types of materials > still display nicely. >- Take a look at the HTML and verify, that label and text are now > wrapped into a new span with a results_* class. >- Try hiding a part of the information, for example in OpacUserCSS: > >.results_material_type { > display none; >} > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Works as described... but for a missing colon on example CSS > >.results_material_type { > display: none; >} > >No koha-qa errors > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >--- > .../prog/en/xslt/MARC21slim2intranetResults.xsl | 27 ++++++++++++++++---- > .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 27 ++++++++++++++++---- > 2 files changed, 44 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >index ee70d86..4e7b24a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >@@ -405,6 +405,7 @@ > <xsl:if test="$DisplayIconsXSLT!='0'"> > <span class="results_summary"> > <xsl:if test="$typeOf008!=''"> >+ <span class="results_material_type"> > <span class="label">Material type: </span> > <xsl:choose> > <xsl:when test="$leader19='a'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/book_link.png" alt="book" title="book" class="materialtype"/> Set</xsl:when> >@@ -425,15 +426,19 @@ > <xsl:when test="$leader6='i'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/sound.png" alt="sound" title="sound" class="materialtype"/> Sound</xsl:when> > <xsl:when test="$leader6='j'"><img src="/intranet-tmpl/prog/img/famfamfam/silk/sound.png" alt="music" title="music" class="materialtype"/> Music</xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > > <xsl:if test="string-length(normalize-space($physicalDescription))"> >- <span class="label">; Format: </span><xsl:copy-of select="$physicalDescription"></xsl:copy-of> >+ <span class="results_format"> >+ <span class="label">; Format: </span><xsl:copy-of select="$physicalDescription"></xsl:copy-of> >+ </span> > </xsl:if> > > <xsl:if test="$controlField008-21 or $controlField008-22 or $controlField008-24 or $controlField008-26 or $controlField008-29 or $controlField008-34 or $controlField008-33 or $controlField008-30-31 or $controlField008-33"> > > <xsl:if test="$typeOf008='CR'"> >+ <span class="results_typeofcontinueing"> > <xsl:if test="$controlField008-21 and $controlField008-21 !='|' and $controlField008-21 !=' '"> > <span class="label">; Type of continuing resource: </span> > </xsl:if> >@@ -451,11 +456,12 @@ > periodical > </xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > <xsl:if test="$typeOf008='BK' or $typeOf008='CR'"> > <xsl:if test="contains($controlField008-24,'abcdefghijklmnopqrstvwxyz')"> >+ <span class="results_natureofcontents"> > <span class="label">; Nature of contents: </span> >- </xsl:if> > <xsl:choose> > <xsl:when test="contains($controlField008-24,'a')"> > abstract or summary >@@ -523,8 +529,11 @@ > conference publication > </xsl:when> > </xsl:choose> >+ </span> >+ </xsl:if> > </xsl:if> > <xsl:if test="$typeOf008='CF'"> >+ <span class="results_typeofcomp"> > <xsl:if test="$controlField008-26='a' or $controlField008-26='e' or $controlField008-26='f' or $controlField008-26='g'"> > <span class="label">; Type of computer file: </span> > </xsl:if> >@@ -533,8 +542,10 @@ > numeric data > </xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > <xsl:if test="$typeOf008='BK'"> >+ <span class="results_contents_literary"> > <xsl:if test="(substring($controlField008,25,1)='j') or (substring($controlField008,25,1)='1') or ($controlField008-34='a' or $controlField008-34='b' or $controlField008-34='c' or $controlField008-34='d')"> > <span class="label">; Nature of contents: </span> > </xsl:if> >@@ -583,8 +594,10 @@ > speech > </xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > <xsl:if test="$typeOf008='MU' and $controlField008-30-31 and $controlField008-30-31!='||' and $controlField008-30-31!=' '"> >+ <span class="results_literaryform"> > <span class="label">; Literary form: </span> <!-- Literary text for sound recordings --> > <xsl:if test="contains($controlField008-30-31,'b')"> > biography >@@ -628,8 +641,10 @@ > <xsl:if test="contains($controlField008-30-31,'l')"> > speech > </xsl:if> >+ </span> > </xsl:if> > <xsl:if test="$typeOf008='VM'"> >+ <span class="results_typeofvisual"> > <span class="label">; Type of visual material: </span> > <xsl:choose> > <xsl:when test="$controlField008-33='a'"> >@@ -671,8 +686,7 @@ > <xsl:when test="$controlField008-33='p'"> > microscope slide > </xsl:when> >- <xsl:when test="$controlField008-33='q' or marc:controlfield[@tag=007][substring(text(),1,1)='a'][substring(text(),2 >-,1)='q']"> >+ <xsl:when test="$controlField008-33='q' or marc:controlfield[@tag=007][substring(text(),1,1)='a'][substring(text(),2,1)='q']"> > model > </xsl:when> > <xsl:when test="$controlField008-33='r'"> >@@ -691,10 +705,12 @@ > toy > </xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > </xsl:if> > > <xsl:if test="($typeOf008='BK' or $typeOf008='CF' or $typeOf008='MU' or $typeOf008='VM') and ($controlField008-22='a' or $controlField008-22='b' or $controlField008-22='c' or $controlField008-22='d' or $controlField008-22='e' or $controlField008-22='g' or $controlField008-22='j' or $controlField008-22='f')"> >+ <span class="results_audience"> > <span class="label">; Audience: </span> > <xsl:choose> > <xsl:when test="$controlField008-22='a'"> >@@ -721,7 +737,8 @@ > <xsl:when test="$controlField008-22='f'"> > Specialized; > </xsl:when> >- </xsl:choose> >+ </xsl:choose> >+ </span> > </xsl:if> > <xsl:text> </xsl:text> <!-- added blank space to fix font display problem, see Bug 3671 --> > </span> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >index e5405b8..0c51ee5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >@@ -549,6 +549,7 @@ > <xsl:if test="$DisplayOPACiconsXSLT!='0'"> > <span class="results_summary type"> > <xsl:if test="$typeOf008!=''"> >+ <span class="results_material_type"> > <span class="label">Material type: </span> > <xsl:choose> > <xsl:when test="$leader19='a'"><img src="/opac-tmpl/lib/famfamfam/silk/book_link.png" alt="book" title="book" class="materialtype"/> Set</xsl:when> >@@ -569,14 +570,18 @@ > <xsl:when test="$leader6='i'"><img src="/opac-tmpl/lib/famfamfam/silk/sound.png" alt="sound" title="sound" class="materialtype"/> Sound</xsl:when> > <xsl:when test="$leader6='j'"><img src="/opac-tmpl/lib/famfamfam/silk/sound.png" alt="music" title="music" class="materialtype"/> Music</xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > <xsl:if test="string-length(normalize-space($physicalDescription))"> >- <span class="label">; Format: </span><xsl:copy-of select="$physicalDescription"></xsl:copy-of> >+ <span class="results_format"> >+ <span class="label">; Format: </span><xsl:copy-of select="$physicalDescription"></xsl:copy-of> >+ </span> > </xsl:if> > > <xsl:if test="$controlField008-21 or $controlField008-22 or $controlField008-24 or $controlField008-26 or $controlField008-29 or $controlField008-34 or $controlField008-33 or $controlField008-30-31 or $controlField008-33"> > > <xsl:if test="$typeOf008='CR'"> >+ <span class="results_typeofcontinuing"> > <xsl:if test="$controlField008-21 and $controlField008-21 !='|' and $controlField008-21 !=' '"> > <span class="label">; Type of continuing resource: </span> > </xsl:if> >@@ -600,11 +605,12 @@ > <img src="/opac-tmpl/lib/famfamfam/silk/world_link.png" alt="web site" title="web site" class="format"/> > </xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > <xsl:if test="$typeOf008='BK' or $typeOf008='CR'"> > <xsl:if test="contains($controlField008-24,'abcdefghijklmnopqrstvwxyz')"> >+ <span class="results_natureofcontents"> > <span class="label">; Nature of contents: </span> >- </xsl:if> > <xsl:choose> > <xsl:when test="contains($controlField008-24,'a')"> > abstract or summary >@@ -676,8 +682,11 @@ > conference publication > </xsl:when> > </xsl:choose> >+ </span> >+ </xsl:if> > </xsl:if> > <xsl:if test="$typeOf008='CF'"> >+ <span class="results_typeofcomp"> > <xsl:if test="$controlField008-26='a' or $controlField008-26='e' or $controlField008-26='f' or $controlField008-26='g'"> > <span class="label">; Type of computer file: </span> > </xsl:if> >@@ -695,8 +704,10 @@ > <img src="/opac-tmpl/lib/famfamfam/silk/controller.png" alt="game" title="game" class="format"/> > </xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > <xsl:if test="$typeOf008='BK'"> >+ <span class="results_contents_literary"> > <xsl:if test="(substring($controlField008,25,1)='j') or (substring($controlField008,25,1)='1') or ($controlField008-34='a' or $controlField008-34='b' or $controlField008-34='c' or $controlField008-34='d')"> > <span class="label">; Nature of contents: </span> > </xsl:if> >@@ -748,8 +759,10 @@ > speech > </xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > <xsl:if test="$typeOf008='MU' and $controlField008-30-31 and $controlField008-30-31!='||' and $controlField008-30-31!=' '"> >+ <span class="results_literaryform"> > <span class="label">; Literary form: </span> <!-- Literary text for sound recordings --> > <xsl:if test="contains($controlField008-30-31,'b')"> > biography >@@ -793,8 +806,10 @@ > <xsl:if test="contains($controlField008-30-31,'l')"> > speech > </xsl:if> >+ </span> > </xsl:if> > <xsl:if test="$typeOf008='VM'"> >+ <span class="results_typeofvisual"> > <span class="label">; Type of visual material: </span> > <xsl:choose> > <xsl:when test="$controlField008-33='a'"> >@@ -836,8 +851,7 @@ > <xsl:when test="$controlField008-33='p'"> > microscope slide > </xsl:when> >- <xsl:when test="$controlField008-33='q' or marc:controlfield[@tag=007][substring(text(),1,1)='a'][substring(text(),2 >-,1)='q']"> >+ <xsl:when test="$controlField008-33='q' or marc:controlfield[@tag=007][substring(text(),1,1)='a'][substring(text(),2,1)='q']"> > model > </xsl:when> > <xsl:when test="$controlField008-33='r'"> >@@ -856,10 +870,12 @@ > toy > </xsl:when> > </xsl:choose> >+ </span> > </xsl:if> > </xsl:if> > > <xsl:if test="($typeOf008='BK' or $typeOf008='CF' or $typeOf008='MU' or $typeOf008='VM') and ($controlField008-22='a' or $controlField008-22='b' or $controlField008-22='c' or $controlField008-22='d' or $controlField008-22='e' or $controlField008-22='g' or $controlField008-22='j' or $controlField008-22='f')"> >+ <span class="results_audience"> > <span class="label">; Audience: </span> > <xsl:choose> > <xsl:when test="$controlField008-22='a'"> >@@ -886,7 +902,8 @@ > <xsl:when test="$controlField008-22='f'"> > Specialized; > </xsl:when> >- </xsl:choose> >+ </xsl:choose> >+ </span> > </xsl:if> > <xsl:text> </xsl:text> <!-- added blank space to fix font display problem, see Bug 3671 --> > </span> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12334
:
31246
|
32858
| 32989