Attachment 33041 Details for Bug 11319 – Bug 11319: Add specific UT for nonexistent field/subfield

[patch] Bug 11319: Add specific UT for nonexistent field/subfield

Bug-11319-Add-specific-UT-for-nonexistent-fieldsub.patch (text/plain), 5.68 KB, created by Marcel de Rooy on 2014-10-31 10:30:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2014-10-31 10:30:32 UTC

Size: 5.68 KB

patch

obsolete

>From 1dd8f203f01fcc5c6f4d0525b03f5f1d52a81c1b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 11 Dec 2013 15:53:37 +0100
>Subject: [PATCH] Bug 11319: Add specific UT for nonexistent field/subfield
>Content-Type: text/plain; charset=utf-8
>
>This patch only adds unit tests for the copy and move actions.
>They test if the action does not create a field/subfield if the source
>did not exist.
>
>Also it adds a unit tests for the existing behavior (in order not to
>lost it): we can use the '^' and the '$' character in regex for
>substituing. For example: Copy 245$a to 245$a with the regex s/^/BEGIN /
>This will add the string "BEGIN " at the beginning of the 245$a fields.
>
>To test: prove t/SimpleMARC.t
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/SimpleMARC.t |   99 +++++++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 files changed, 95 insertions(+), 4 deletions(-)
>
>diff --git a/t/SimpleMARC.t b/t/SimpleMARC.t
>index fff1096..fc6ad5f 100644
>--- a/t/SimpleMARC.t
>+++ b/t/SimpleMARC.t
>@@ -269,7 +269,7 @@ subtest 'update_field' => sub {
> subtest 'copy_field' => sub {
>     plan tests              => 2;
>     subtest 'copy subfield' => sub {
>-        plan tests => 15;
>+        plan tests => 18;
>         my $record = new_record;
>         $record->append_fields(
>             MARC::Field->new(
>@@ -547,10 +547,63 @@ subtest 'copy_field' => sub {
>             [ '2001-06-25', '2001-06-25' ],
>             'copy 952$d into others 952 field'
>         );
>+
>+        copy_field(
>+            {
>+                record        => $record,
>+                from_field    => '111',
>+                from_subfield => '1',
>+                to_field      => '999',
>+                to_subfield   => '9'
>+            }
>+        );
>+        my @fields_9999 =
>+          read_field( { record => $record, field => '999', subfield => '9' } );
>+        is_deeply( \@fields_9999, [],
>+            'copy a nonexistent subfield does not create a new one' );
>+
>+        $record = new_record;
>+        copy_field(
>+            {
>+                record        => $record,
>+                from_field    => 245,
>+                from_subfield => 'a',
>+                to_field      => 245,
>+                to_subfield   => 'a',
>+                regex         => { search => '^', replace => 'BEGIN ' }
>+            }
>+        );
>+        is_deeply(
>+            read_field(
>+                { record => $record, field => '245', subfield => 'a' }
>+            ),
>+            'BEGIN The art of computer programming',
>+            'Update a subfield: add a string at the beginning'
>+        );
>+
>+        $record = new_record;
>+        copy_field(
>+            {
>+                record        => $record,
>+                from_field    => 245,
>+                from_subfield => 'a',
>+                to_field      => 245,
>+                to_subfield   => 'a',
>+                regex         => { search => '$', replace => ' END' }
>+            }
>+        );
>+        is_deeply(
>+            read_field(
>+                { record => $record, field => '245', subfield => 'a' }
>+            ),
>+            'The art of computer programming END',
>+            'Update a subfield: add a string at the end'
>+        );
>+
>     };
> 
>     subtest 'copy field' => sub {
>-        plan tests => 11;
>+        plan tests => 12;
>         my $record = new_record;
>         $record->append_fields(
>             MARC::Field->new(
>@@ -648,6 +701,17 @@ subtest 'copy_field' => sub {
>             [ '4242423918', 'CD' ],
>             "copy all with regex: second original fields has been copied"
>         );
>+        copy_field(
>+            {
>+                record     => $record,
>+                from_field => '111',
>+                to_field   => '999',
>+            }
>+        );
>+        my @fields_9999 =
>+          read_field( { record => $record, field => '999', subfield => '9' } );
>+        is_deeply( \@fields_9999, [],
>+            'copy a nonexistent field does not create a new one' );
>     };
> };
> 
>@@ -655,7 +719,7 @@ subtest 'copy_field' => sub {
> subtest 'move_field' => sub {
>     plan tests              => 2;
>     subtest 'move subfield' => sub {
>-        plan tests => 6;
>+        plan tests => 7;
>         my $record = new_record;
>         my ( @fields_952d, @fields_952c, @fields_954c, @fields_954p );
>         $record->append_fields(
>@@ -726,10 +790,24 @@ subtest 'move_field' => sub {
>             [ '3010023917', '3010023917' ],
>             'Now 2 954$p exist'
>         );
>+
>+        move_field(
>+            {
>+                record        => $record,
>+                from_field    => '111',
>+                from_subfield => '1',
>+                to_field      => '999',
>+                to_subfield   => '9'
>+            }
>+        );
>+        my @fields_9999 =
>+          read_field( { record => $record, field => '999', subfield => '9' } );
>+        is_deeply( \@fields_9999, [],
>+            'move a nonexistent subfield does not create a new one' );
>     };
> 
>     subtest 'move field' => sub {
>-        plan tests => 8;
>+        plan tests => 9;
> 
>         # move_field - fields
>         my $record = new_record;
>@@ -807,6 +885,19 @@ subtest 'move_field' => sub {
>             [ '3010023917', 'DVD' ],
>             "use a regex, second original fields has been copied"
>         );
>+
>+        move_field(
>+            {
>+                record     => $record,
>+                from_field => '111',
>+                to_field   => '999',
>+            }
>+        );
>+        my @fields_9999 =
>+          read_field( { record => $record, field => '999', subfield => '9' } );
>+        is_deeply( \@fields_9999, [],
>+            'move a nonexistent field does not create a new one' );
>+
>     };
> };
> 
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 11319: 23206 | 23414 | 23415 | 23416 | 23417 | 23418 | 23419 | 24650 | 25751 | 25752 | 25753 | 25754 | 25755 | 28988 | 28989 | 28990 | 28991 | 28992 | 29497 | 29498 | 29499 | 29500 | 29501 | 31343 | 33029 | 33030 | 33038 | 33039 | 33040 | 33041 | 33042 | 33043 | 33044