Bugzilla – Attachment 33178 Details for
Bug 12886
shelfbrowser script should write headers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12886: shelfbrowser script should write headers
PASSED-QA-Bug-12886-shelfbrowser-script-should-wri.patch (text/plain), 1.14 KB, created by
Katrin Fischer
on 2014-11-03 21:47:05 UTC
(
hide
)
Description:
[PASSED QA] Bug 12886: shelfbrowser script should write headers
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-11-03 21:47:05 UTC
Size:
1.14 KB
patch
obsolete
>From a375df7e51fb1e8d73305c607d84363dfdf92d00 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 8 Sep 2014 16:09:22 +0200 >Subject: [PATCH] [PASSED QA] Bug 12886: shelfbrowser script should write > headers > >opac/svc/shelfbrowser.pl does not write http headers. > >On a production server, this patch resolves a server internal error >(500): > Bad header= <div id="shelfbrowser"> > >I did not reproduce on my local instance, but this should be fixed. > >Test plan: >Verify there is no regression on browsing a shelf (with "en" and translated >templates) > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes tests and QA script, no regressions found. >--- > opac/svc/shelfbrowser.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/svc/shelfbrowser.pl b/opac/svc/shelfbrowser.pl >index 33c9cde..611c503 100755 >--- a/opac/svc/shelfbrowser.pl >+++ b/opac/svc/shelfbrowser.pl >@@ -38,4 +38,4 @@ if (C4::Context->preference("OPACShelfBrowser")) { > } > } > >-print $template->output; >+output_html_with_http_headers $cgi, $cookie, $template->output; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12886
:
31462
|
32351
|
33142
| 33178