Attachment 33199 Details for Bug 12944 – Bug 12944 [Patron lists follow-up] There is no way to search orders by creator

[patch] Bug 12944 [Patron lists follow-up] There is no way to search orders by creator

Bug-12944-Patron-lists-follow-up-There-is-no-way-t.patch (text/plain), 2.37 KB, created by Jonathan Druart on 2014-11-04 14:06:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-11-04 14:06:35 UTC

Size: 2.37 KB

patch

obsolete

>From 68ff2dc02be9c9526a965b39da1bb6cd286a6fbe Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 29 Oct 2014 10:53:07 -0400
>Subject: [PATCH] Bug 12944 [Patron lists follow-up] There is no way to search
> orders by creator
>
>This bug modifies not just the order search form but also the patron
>lists feature, making use of the new script for building a patron
>autocomplete form. However, the test plan does not specify that the
>patron lists form be tested as well, and it doesn't work.
>
>This patch corrects a minor flaw which broke the patron search
>autocomplete when adding patrons to a patron list.
>
>To test, create a new patron list if necessary. Click the "add patrons"
>button to add patrons to the list. In the patron search form type a
>partial patron name. You should get an autocomplete dropdown of existing
>patrons. Selecting one should work correctly.
>
>Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt  | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt
>index 75bc842..76ebc8e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt
>@@ -6,7 +6,7 @@
> [% INCLUDE 'calendar.inc' %]
> [% INCLUDE 'datatables.inc' %]
> 
>-<script type="text/javascript" src="[% interface %]/js/autocomplete/patrons.pl"></script>
>+<script type="text/javascript" src="[% interface %]/js/autocomplete/patrons.js"></script>
> <script type="text/javascript">
> //<![CDATA[
>  $(document).ready(function() {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt
>index 32d7580..8c45a45 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt
>@@ -24,7 +24,7 @@ $(document).ready(function() {
>     patron_autocomplete({
>         patron_container: $("#patrons_to_add"),
>         input_autocomplete: $("#find_patron"),
>-        patron_input_name = 'patrons_to_add'
>+        patron_input_name: 'patrons_to_add'
>     });
> 
>     var checkBoxes = $("input[type='checkbox']","#patron-list-table");
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 12944: 31682 | 31683 | 31824 | 31825 | 31987 | 31988 | 31989 | 32922 | 32931 | 33197 | 33198 | 33199 | 33200 | 34781 | 35589 | 35590 | 35591 | 35592 | 35593 | 35698