Bugzilla – Attachment 33220 Details for
Bug 13144
Google transliteration does not work on bootstrap
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13144: Google transliteration does not work on bootstrap
Bug-13144-Google-transliteration-does-not-work-on-.patch (text/plain), 3.30 KB, created by
Frédéric Demians
on 2014-11-05 07:15:21 UTC
(
hide
)
Description:
Bug 13144: Google transliteration does not work on bootstrap
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2014-11-05 07:15:21 UTC
Size:
3.30 KB
patch
obsolete
>From 13913976f45c1c54d08f7ba26969dedab73ae2d9 Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Tue, 4 Nov 2014 21:33:36 +0530 >Subject: [PATCH] Bug 13144: Google transliteration does not work on bootstrap > >To Test: >Use Google Indic Transliteration API to allow users to >transliterate english typed words into Indic languages. >http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 > >Signed-off-by: Frederic Demians <f.demians@tamil.fr> > >I had been able to reproduce the bug (a regression), and I can confirm that >this patch fix it. But I had to create manualy GoogleIndicTransliteration >system preference, which doesn't exist in standard .pref file. It may be >necessary to add it. In my opinion, it shouldn't prevent to include this patch. >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/js/googleindictransliteration.js | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 5355d75..94dec72 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -197,9 +197,9 @@ > <div class="input-append nolibrarypulldown"> > [% END %] > [% IF ( ms_value ) %] >- <input type="text" title="Type search term" class="transl1" name="q" value="[% ms_value |html %]" /><span id="translControl"></span> >+ <input type="text" title="Type search term" class="transl1" id = "translControl1" name="q" value="[% ms_value |html %]" /><span id="translControl"></span> > [% ELSE %] >- <input type="text" title="Type search term" class="transl1" name="q" /><span id="translControl"></span> >+ <input type="text" title="Type search term" class="transl1" id = "translControl1" name="q" /><span id="translControl"></span> > [% END # /ms_value %] > > [% UNLESS ( Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/googleindictransliteration.js b/koha-tmpl/opac-tmpl/bootstrap/js/googleindictransliteration.js >index a251cef..027ad61 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/googleindictransliteration.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/googleindictransliteration.js >@@ -8,7 +8,7 @@ > sourceLanguage: 'en', > destinationLanguage: ['hi','kn','ml','ta','te'], > shortcutKey: 'ctrl+g', >- transliterationEnabled: true >+ transliterationEnabled: false > }; > > // Create an instance on TransliterationControl with the required >@@ -17,7 +17,7 @@ > new google.elements.transliteration.TransliterationControl(options); > > // Enable transliteration in the textfields with the given ids. >- var ids = [ "transl1" ]; >+ var ids = [ "translControl1" ]; > control.makeTransliteratable(ids); > > // Show the transliteration control which can be used to toggle between >-- >2.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13144
:
33202
|
33220
|
33272
|
33301