Bugzilla – Attachment 33221 Details for
Bug 13194
Tiny typo in POD for SetMessagingPreferencesFromDefaults
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 13194: Fix typo in SetMessagingPreferencesFromDefaults POD
SIGNED-OFF-Bug-13194-Fix-typo-in-SetMessagingPrefe.patch (text/plain), 1.60 KB, created by
Mark Tompsett
on 2014-11-05 07:19:38 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 13194: Fix typo in SetMessagingPreferencesFromDefaults POD
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2014-11-05 07:19:38 UTC
Size:
1.60 KB
patch
obsolete
>From d71dc0b5cfab1373f0a1611700b0d917a2110553 Mon Sep 17 00:00:00 2001 >From: Magnus Enger <magnus@enger.priv.no> >Date: Tue, 4 Nov 2014 14:03:16 +0100 >Subject: [PATCH] [SIGNED OFF] Bug 13194: Fix typo in > SetMessagingPreferencesFromDefaults POD > >The example usage for >C4::Members::Messaging::SetMessagingPreferencesFromDefaults >calls the subroutine SetMessagingPreferenceFromDefaults, not >SetMessagingPreferencesFromDefaults (missing the 's' at the >end of 'Preferences'). > >To test: >- Apply the patch >- Check that the POD now refers to the actual name of the > subroutine > (perldoc C4::Members::Messaging) > >http://bugs.koha-community.org/show_bug.cgi?id=13194 > >Adding 's' is the correct doc change to make it match with >the function definition. Comfirmable with less. >perldoc C4::Members::Messaging proves the doc is still nice. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > C4/Members/Messaging.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Members/Messaging.pm b/C4/Members/Messaging.pm >index 6be8347..f28c3dc 100644 >--- a/C4/Members/Messaging.pm >+++ b/C4/Members/Messaging.pm >@@ -223,7 +223,7 @@ END_SQL > > =head2 SetMessagingPreferencesFromDefaults > >- C4::Members::Messaging::SetMessagingPreferenceFromDefaults( { borrowernumber => $borrower->{'borrowernumber'} >+ C4::Members::Messaging::SetMessagingPreferencesFromDefaults( { borrowernumber => $borrower->{'borrowernumber'} > categorycode => 'CPL' } ); > > Given a borrowernumber and a patron category code (from the C<borrowernumber> and C<categorycode> keys >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13194
:
33195
|
33221
|
33250