Bugzilla – Attachment 33224 Details for
Bug 13200
Followup of Bug 12246 - noisy C4/Auth.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm
SIGNED-OFF-Bug-13200---Followup-of-Bug-12246---noi.patch (text/plain), 1.87 KB, created by
Martin Renvoize (ashimema)
on 2014-11-05 08:31:51 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2014-11-05 08:31:51 UTC
Size:
1.87 KB
patch
obsolete
>From 467314b93f428b04a7cf3b6717875aecc8ab7f4a Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 5 Nov 2014 03:06:42 -0500 >Subject: [PATCH] [SIGNED OFF] Bug 13200 - Followup of Bug 12246 - noisy > C4/Auth.pm > >While testing a bug, warnings in the opac error log were >building up due to a particular line in C4::Auth. After >reviewing the code, it was discovered that removal of the >OpacMainUserBlockMobile system preference created this. > >Since the system preference no longer exists, and is not >used, the line was deleted from C4/Auth.pm to prevent this >warning from occuring. > >TEST PLAN >---------- >1) Go to any OPAC page. >2) Check your opac error log. > -- there should be something about uninitialized values > used in C4/Auth.pm around line 443. >3) Apply the patch >4) Refresh the page. > -- that same error should not be triggered. >5) prove -v t/db_dependent/Auth.t > -- this runs the get_template_and_user function > which had the parameter removed. >6) run the koha qa test tools > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Auth.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index c6dda85..16d3ec2 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -467,7 +467,6 @@ sub get_template_and_user { > OpacCloud => C4::Context->preference("OpacCloud"), > OpacKohaUrl => C4::Context->preference("OpacKohaUrl"), > OpacMainUserBlock => "" . C4::Context->preference("OpacMainUserBlock"), >- OpacMainUserBlockMobile => "" . C4::Context->preference("OpacMainUserBlockMobile"), > OpacNav => "" . C4::Context->preference("OpacNav"), > OpacNavRight => "" . C4::Context->preference("OpacNavRight"), > OpacNavBottom => "" . C4::Context->preference("OpacNavBottom"), >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13200
:
33223
|
33224
|
33249