Bugzilla – Attachment 33243 Details for
Bug 13201
GetSuggestion takes suggestionid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13201: GetSuggestion takes suggestionid
Bug-13201-GetSuggestion-takes-suggestionid.patch (text/plain), 1.35 KB, created by
Jonathan Druart
on 2014-11-05 11:42:47 UTC
(
hide
)
Description:
Bug 13201: GetSuggestion takes suggestionid
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-11-05 11:42:47 UTC
Size:
1.35 KB
patch
obsolete
>From 5adc09351af05ecc43c5b6dd8e038386a9085fbe Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 5 Nov 2014 12:41:13 +0100 >Subject: [PATCH] Bug 13201: GetSuggestion takes suggestionid > >Test plan: >Verify the tests for suggestions still passed and that the changes are >consistent (just looking at the code). >--- > C4/Suggestions.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm >index 5070e7d..426e749 100644 >--- a/C4/Suggestions.pm >+++ b/C4/Suggestions.pm >@@ -202,9 +202,9 @@ sub SearchSuggestion { > > =head2 GetSuggestion > >-\%sth = &GetSuggestion($ordernumber) >+\%sth = &GetSuggestion($suggestionid) > >-this function get the detail of the suggestion $ordernumber (input arg) >+this function get the detail of the suggestion $suggestionid (input arg) > > return : > the result of the SQL query as a hash : $sth->fetchrow_hashref. >@@ -212,7 +212,7 @@ return : > =cut > > sub GetSuggestion { >- my ($ordernumber) = @_; >+ my ($suggestionid) = @_; > my $dbh = C4::Context->dbh; > my $query = q{ > SELECT * >@@ -220,7 +220,7 @@ sub GetSuggestion { > WHERE suggestionid=? > }; > my $sth = $dbh->prepare($query); >- $sth->execute($ordernumber); >+ $sth->execute($suggestionid); > return ( $sth->fetchrow_hashref ); > } > >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13201
:
33243
|
33282
|
33349