Attachment 33264 Details for Bug 12851 – Bug 12851: order tags should be removed from the claiming letter

[patch] Bug 12851: order tags should be removed from the claiming letter

Bug-12851-order-tags-should-be-removed-from-the-cl.patch (text/plain), 1.45 KB, created by Jonathan Druart on 2014-11-05 16:37:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-11-05 16:37:56 UTC

Size: 1.45 KB

patch

obsolete

>From ff3cc83c857c43eebc66f3030afcd5c88e27c10d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 5 Nov 2014 17:33:03 +0100
>Subject: [PATCH] Bug 12851: order tags should be removed from the claiming
> letter
>
>If you use a claimissue notice to claim serials, the generated letter
>will be
>
><order>Title1, Author1</order>
><order>Title2, Author2</order>
>...
><order>TitleN, AuthorN</order>
>
>This patch geds rid of these tags.
>
>Test plan:
>1/ Create a claimissue notice with something like:
>  <<LibrarianFirstname>>
>  <<LibrarianSurname>>
>  The following issues are in late:
>  <order><<biblio.title>>, <<biblio.author>> (<<biblio.serial>>)</order>
>
>2/ Generated late serial issues.
>3/ Send notifications to vendor.
>4/ The order tags should not exist anymore in the sent email.
>
>You can see bug 5342 for a more detailled test plan.
>
>Note that the order tag is needed for repeatable elements describe on several
>lines.
>---
> C4/Letters.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 519c0f6..3c7ca2f 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -362,7 +362,7 @@ sub SendAlerts {
>                 'aqbooksellers' => $databookseller,
>                 'aqcontacts'    => $datacontact,
>             },
>-            repeat => $dataorders,
>+            repeat => { order => [ map { biblio => $_, biblioitems => $_ }, @$dataorders ] },
>             want_librarian => 1,
>         ) or return;
> 
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 12851: 31276 | 33264 | 33739 | 33770 | 33924