Bugzilla – Attachment 33345 Details for
Bug 12017
Move language description out of database
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12017 - 9 - Remove use of language_get_description function
Bug-12017---9---Remove-use-of-languagegetdescripti.patch (text/plain), 2.98 KB, created by
Bernardo Gonzalez Kriegel
on 2014-11-06 18:56:55 UTC
(
hide
)
Description:
Bug 12017 - 9 - Remove use of language_get_description function
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2014-11-06 18:56:55 UTC
Size:
2.98 KB
patch
obsolete
>From 4ab83ac0156dbc6dfc7442351182d1dae3b3b2f1 Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Sun, 27 Apr 2014 21:17:14 -0300 >Subject: [PATCH] Bug 12017 - 9 - Remove use of language_get_description > function > >This patch removes every use of language_get_description >function. This function retrieves lang names from database > >To test: >1. Functionality removed by this patch do not >affect anything, because previous patches are >only using rfc4646_subtag value, not values stored >in database. >2. Removed import from Templates.pm, not used there >--- > C4/Languages.pm | 5 ----- > C4/Templates.pm | 2 +- > 2 files changed, 1 insertion(+), 6 deletions(-) > >diff --git a/C4/Languages.pm b/C4/Languages.pm >index e453c80..d8c7435 100644 >--- a/C4/Languages.pm >+++ b/C4/Languages.pm >@@ -397,10 +397,6 @@ sub _build_languages_arrayref { > # group this language, key by langtag > $language_subtags_hashref->{'sublanguage_current'} = 1 if $translated_language eq $current_language; > $language_subtags_hashref->{'rfc4646_subtag'} = $translated_language; >- $language_subtags_hashref->{'native_description'} = language_get_description($language_subtags_hashref->{language},$language_subtags_hashref->{language},'language'); >- $language_subtags_hashref->{'script_description'} = language_get_description($language_subtags_hashref->{script},$language_subtags_hashref->{'language'},'script'); >- $language_subtags_hashref->{'region_description'} = language_get_description($language_subtags_hashref->{region},$language_subtags_hashref->{'language'},'region'); >- $language_subtags_hashref->{'variant_description'} = language_get_description($language_subtags_hashref->{variant},$language_subtags_hashref->{'language'},'variant'); > $track_language_groups->{$language_subtags_hashref->{'language'}}++; > push ( @{ $language_groups->{$language_subtags_hashref->{language}} }, $language_subtags_hashref ); > } >@@ -416,7 +412,6 @@ sub _build_languages_arrayref { > push @languages_loop, { > # this is only use if there is one > rfc4646_subtag => @$value[0]->{rfc4646_subtag}, >- native_description => language_get_description($key,$key,'language'), > language => $key, > sublanguages_loop => $value, > plural => $track_language_groups->{$key} >1 ? 1 : 0, >diff --git a/C4/Templates.pm b/C4/Templates.pm >index d53d1a8..e2f2457 100644 >--- a/C4/Templates.pm >+++ b/C4/Templates.pm >@@ -32,7 +32,7 @@ use List::MoreUtils qw/any uniq/; > use base qw(Class::Accessor); > use Template; > use Template::Constants qw( :debug ); >-use C4::Languages qw(getTranslatedLanguages get_bidi regex_lang_subtags language_get_description accept_language ); >+use C4::Languages qw(getTranslatedLanguages get_bidi regex_lang_subtags accept_language ); > > use C4::Context; > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12017
:
26691
|
26694
|
26735
|
26736
|
26770
|
27687
|
27688
|
27689
|
27690
|
27691
|
27692
|
27693
|
27694
|
27695
|
27696
|
29898
|
29899
|
29900
|
29901
|
29902
|
29903
|
29904
|
29905
|
29906
|
29907
|
33337
|
33338
|
33339
|
33340
|
33341
|
33342
|
33343
|
33344
|
33345
|
33346
|
39304
|
39305
|
39306
|
39307
|
39308
|
39309
|
39310
|
39311
|
39312
|
39313
|
39644
|
39655
|
39656
|
39657
|
39658
|
39659
|
39660
|
39661
|
39662
|
39663
|
39664
|
39665
|
40285
|
40286
|
40287
|
40288
|
40289
|
40290
|
40291
|
40292
|
40293
|
40294
|
40295