Bugzilla – Attachment 33389 Details for
Bug 13218
usability enhancement for z39.50 search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13218 - usability enhancements for z39.50 searches
Bug-13218---usability-enhancements-for-z3950-searc.patch (text/plain), 8.50 KB, created by
Liz Rea
on 2014-11-08 02:26:19 UTC
(
hide
)
Description:
Bug 13218 - usability enhancements for z39.50 searches
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2014-11-08 02:26:19 UTC
Size:
8.50 KB
patch
obsolete
>From 3f8275c8f7e6e3fbfbebb7c973b99c71d6d00e16 Mon Sep 17 00:00:00 2001 >From: Liz <wizzyrea@gmail.com> >Date: Thu, 6 Nov 2014 08:29:02 +0000 >Subject: [PATCH] Bug 13218 - usability enhancements for z39.50 searches > >This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. >There should be no functional change to z-target searching, all functions should remain the same. > >Changes: >* 2 columns of search fields condensed into one >* zTargets moved from below the search fields to beside them >* rearranged search fields into perceived frequency of usage, from most used to least >* changed label of Raw (any) to Keyword (any) > >To test: >* click cataloguing -> new from z39.50/SRU >* observe how the layout has changed >* import a record or two using the search - there has been no change to the function, it should all be working. > >* Click Authorities -> new from z39.50 >* observe how the layout has changed >* import an authority or two using the search - there has been no change to the function, it should all be working. > >* sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. >--- > .../prog/en/includes/authorities-toolbar.inc | 2 +- > .../prog/en/modules/cataloguing/addbooks.tt | 2 +- > .../en/modules/cataloguing/z3950_auth_search.tt | 7 ------ > .../prog/en/modules/cataloguing/z3950_search.tt | 24 ++++++++------------ > 4 files changed, 11 insertions(+), 24 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc >index ff96505..203e9a0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc >@@ -7,7 +7,7 @@ > }); > > $("#z3950submit").click(function(){ >- window.open("/cgi-bin/koha/cataloguing/z3950_auth_search.pl","z3950search",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); >+ window.open("/cgi-bin/koha/cataloguing/z3950_auth_search.pl","z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); > return false; > }); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >index 8a02dd5..39d9937 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >@@ -24,7 +24,7 @@ > function PopupZ3950(fw) { > var strQuery = GetZ3950Terms(fw); > if(strQuery){ >- window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber %]"+strQuery,"z3950search",'width=760,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); >+ window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); > } > } > /* provide Z3950 search points */ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >index 26724a1..5965dcf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >@@ -113,12 +113,6 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > <li><label for="authorpersonal">Author (personal): </label> <input type="text" id="authorpersonal" name="authorpersonal" value="" /></li> > <li><label for="authorcorp">Author (corporate): </label> <input type="text" id="authorcorp" name="authorcorp" value="" /></li> > <li><label for="authormeetingcon">Author (meeting/conference): </label> <input type="text" id="authormeetingcon" name="authormeetingcon" value="" /></li> >- </ol> >- </fieldset> >- </div> >- <div class="yui-u"> >- <fieldset class="rows"> >- <ol> > <li><label for="subject">Subject heading: </label> <input type="text" id="subject" name="subject" value="" /></li> > <li><label for="subjectsubdiv">Subject sub-division: </label> <input type="text" id="subjectsubdiv" name="subjectsubdiv" value="" /></li> > <li><label for="title">Title (any): </label> <input type="text" id="title" name="title" value="[% title |html %]" /></li> >@@ -126,7 +120,6 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > </ol> > </fieldset> > </div> >- </div> > <div class="yui-g"> > <h2>Search targets <span style="display: inline; font-size: 70%; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#">Select all</a></span><span class="clearall"><a id="CheckNone" href="#">Clear all</a></span></span></h2> > [% FOREACH serverloo IN serverloop %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >index 1387cef..c710c0c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >@@ -107,25 +107,20 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > <div class="yui-g"> > <div class="yui-u first"> > <fieldset class="rows"> >- <ol><li><label for="title">Title: </label> <input type="text" id="title" name="title" value="[% title |html %]" /></li> >+ <ol> > <li><label for="isbn">ISBN: </label> <input type="text" id="isbn" name="isbn" value="[% isbn %]" /></li> >+ <li><label for="issn">ISSN: </label> <input type="text" id="issn" name="issn" value="[% issn %]" /></li> >+ <li><label for="title">Title: </label> <input type="text" id="title" name="title" value="[% title |html %]" /></li> >+ <li><label for="author">Author: </label> <input type="text" id="author" name="author" value="[% author %]" /></li> >+ <li><label for="subject">Subject heading: </label> <input type="text" id="subject" name="subject" value="" /></li> >+ <li><label for="srchany">Keyword (any): </label> <input type="text" id="srchany" name="srchany" value="" /></li> > <li><label for="lccall">LC call number: </label> <input type="text" id="lccall" name="lccall" value="" /></li> > <li><label for="controlnumber">Control no.: </label> <input type="text" id="controlnumber" name="controlnumber" value="" /></li> >- <li><label for="srchany">Raw (any): </label> <input type="text" id="srchany" name="srchany" value="" /></li></ol> >- </fieldset> >- </div> >- <div class="yui-u"> >- <fieldset class="rows"> >- <ol> >- <li><label for="author">Author: </label> <input type="text" id="author" name="author" value="[% author %]" /></li> >- <li><label for="issn">ISSN: </label> <input type="text" id="issn" name="issn" value="[% issn %]" /></li> >- <li> <label for="subject">Subject heading: </label> <input type="text" id="subject" name="subject" value="" /></li> >- <li><label for="dewey">Dewey: </label> <input type="text" id="dewey" name="dewey" value="" /></li> >- <li><label for="stdid">Standard ID: </label> <input type="text" id="stdid" name="stdid" value="" /></li></ol> >- </fieldset> >+ <li><label for="dewey">Dewey: </label> <input type="text" id="dewey" name="dewey" value="" /></li> >+ <li><label for="stdid">Standard ID: </label> <input type="text" id="stdid" name="stdid" value="" /></li> >+ </ol> > <input type="hidden" name="biblionumber" value="[% biblionumber %]" /> > <input type="hidden" name="frameworkcode" value="[% frameworkcode %]" /> >- </div> > </div> > <div class="yui-g"> > <h2>Search targets <span style="display: inline; font-size: 70%; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#">Select all</a></span><span class="clearall"><a id="CheckNone" href="#">Clear all</a></span></span></h2> >@@ -160,7 +155,6 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > [% IF ( srchany ) %]<em>Raw (any): </em><span class=term>[% srchany %]</span> [% END %] > [% IF ( stdid ) %]<em>Standard ID: </em><span class=term>[% stdid %]</span> [% END %] > </p> >- > [% IF ( errconn ) %] > <div class="dialog alert"> > <ul> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13218
:
33367
|
33382
|
33383
|
33389
|
33393
|
33728
|
33747
|
33768
|
34246
|
34270
|
34271
|
34272
|
34497
|
34498
|
34499
|
34585