Attachment 33395 Details for Bug 10878 – Bug 10878: Correct Display856uAsImage pref description

[patch] Bug 10878: Correct Display856uAsImage pref description

Bug-10878-Correct-Display856uAsImage-pref-descript.patch (text/plain), 3.48 KB, created by Katrin Fischer on 2014-11-09 21:29:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-11-09 21:29:31 UTC

Size: 3.48 KB

patch

obsolete

>From 009baab3bfd04aec5bf78b5d4beabbdfcd8574f3 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Sun, 9 Nov 2014 22:25:32 +0100
>Subject: [PATCH] Bug 10878: Correct Display856uAsImage pref description
>
>Removes note about Display856uAsImage not working on
>the OPAC result page.
>
>To test:
>- catalog a record with 856$u = URL to an image, $q = img
>- turn on the system preference Display856uAsImage
>- check that the pref description makes sense and is correct
>  - the warning about the pref not working on result pages
>    has been removed
>- make sure your record has been reindexed by Zebra
>- verifiy the image indeed displays on the result page
>  in the bootstrap catalog.
>
>Note: The height=100 doesn't work in the Boostrap catalog,
>so the images display in their original size. Will file
>a separate bug for this.
>---
> .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref  | 10 +++++-----
> .../prog/en/modules/admin/preferences/staff_client.pref        | 10 +++++-----
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 6b25a01..23e99e4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -260,11 +260,11 @@ OPAC:
>             - 'Display the URI in the 856u field as an image on: '
>             - pref: OPACDisplay856uAsImage
>               choices:
>-                  OFF: "Neither Details or Results pages"
>-                  Details: "Details page only"
>-                  Results: "Results page only"
>-                  Both: "Both Details and Results pages"
>-            - 'Note: The corresponding OPACXSLT option must be turned on.'
>+                  OFF: "Neither detail or result pages"
>+                  Details: "Detail page only"
>+                  Results: "Result page only"
>+                  Both: "Both detail and result pages"
>+            - '. Note: The corresponding OPACXSLT option must be turned on.'
>         -
>             - 'List export options that should be available from OPAC detail page separated by |:'
>             - pref: OpacExportOptions
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
>index bbadc70..0cbaee0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
>@@ -81,11 +81,11 @@ Staff Client:
>             - 'Display the URI in the 856u field as an image on: '
>             - pref: Display856uAsImage
>               choices:
>-                  OFF: "Neither Details or Results pages"
>-                  Details: "Details page only"
>-                  Results: "Results page (for future use, Results XSLT not functional at this time)."
>-                  Both: "Both Results and Details pages (for future use, Results XSLT not functional at this time)."
>-            - 'Note: The corresponding XSLT option must be turned on.'
>+                  OFF: "Neither detail or result pages"
>+                  Details: "Detail page only"
>+                  Results: "Result page"
>+                  Both: "Both result and detail pages"
>+            - '. Note: The corresponding XSLT option must be turned on.'
>         -
>             - Include the stylesheet at
>             - pref: SlipCSS
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 10878: 33395 | 33406 | 33472