Bugzilla – Attachment 33409 Details for
Bug 12264
Tiny typo in t/db_dependent/Items.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12264: [QA Follow-up] Fixing biblionumber/biblioitemnumber mixup
Bug-12264-QA-Follow-up-Fixing-biblionumberbiblioit.patch (text/plain), 1.61 KB, created by
Marcel de Rooy
on 2014-11-10 08:33:04 UTC
(
hide
)
Description:
Bug 12264: [QA Follow-up] Fixing biblionumber/biblioitemnumber mixup
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-11-10 08:33:04 UTC
Size:
1.61 KB
patch
obsolete
>From fc4e874954947a7748b3f56a6551ff0013e07616 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 10 Nov 2014 09:21:46 +0100 >Subject: [PATCH] Bug 12264: [QA Follow-up] Fixing > biblionumber/biblioitemnumber mixup >Content-Type: text/plain; charset=utf-8 > >While testing the string change on 12264, I had this result: >DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191. >DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191. > # Child (GetItemsInfo tests) exited without calling finalize() >not ok 4 - GetItemsInfo tests > >This was caused by this line in the unit test: > my $biblionumber = get_biblio(); >This routine returns: > return ($bibnum, $bibitemnum); >So instead of the bibnum the bibitemnum is saved in biblionumber. >In my test database bibnum and bibitemnum somehow got out of sync, revealing >this bug :) >The fix is just adding parentheses: > my ( $biblionumber ) = get_biblio(); > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Items.t | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index 6d8b47f..d537888 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -165,7 +165,7 @@ subtest 'GetItemsInfo tests' => sub { > my $holdingbranch = 'MPL'; > > # Add a biblio >- my $biblionumber = get_biblio(); >+ my ($biblionumber) = get_biblio(); > # Add an item > my ($item_bibnum, $item_bibitemnum, $itemnumber) > = AddItem({ >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12264
:
33397
|
33405
|
33408
| 33409