Attachment 33435 Details for Bug 10459 – [SIGNED_OFF] Bug 10459: Borrowers should have a timestamp

[patch] [SIGNED_OFF] Bug 10459: Borrowers should have a timestamp

Bug-10459-Borrowers-should-have-a-timestamp.patch (text/plain), 3.73 KB, created by Marc Véron on 2014-11-10 17:26:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2014-11-10 17:26:24 UTC

Size: 3.73 KB

patch

obsolete

>From 9ed6027332df65372895c11381585aeeb5752c38 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 10 Nov 2014 14:17:40 +0100
>Subject: [PATCH] Bug 10459: Borrowers should have a timestamp
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch adds a timestamp column to the borrowers table in kohastructure
>and updatedatabase. (And also to the deletedborrowers table.)
>A timestamp may be useful in synchronizing with external systems (among other
>reasons).
>
>Test plan:
>Run updatestructure on an existing database, or install a new one.
>Verify that the borrowers table has a timestamp now.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Tested updatestructure and running kohastructure.sql.
>Passed t/db_dependent/Members.t.
>
>updatedatabase.pl did not apply. I edited and then run it. Columns were added as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> installer/data/mysql/kohastructure.sql |    2 ++
> installer/data/mysql/updatedatabase.pl |   12 ++++++++++++
> 2 files changed, 14 insertions(+)
>
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 8c777f7..0aac77d 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -265,6 +265,7 @@ CREATE TABLE `borrowers` ( -- this table includes information about your patrons
>   `altcontactphone` varchar(50) default NULL, -- the phone number for the alternate contact for the patron/borrower
>   `smsalertnumber` varchar(50) default NULL, -- the mobile phone number where the patron/borrower would like to receive notices (if SNS turned on)
>   `privacy` integer(11) DEFAULT '1' NOT NULL, -- patron/borrower's privacy settings related to their reading history
>+  `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, -- time of last change could be useful for synchronization with external systems (among others)
>   UNIQUE KEY `cardnumber` (`cardnumber`),
>   PRIMARY KEY `borrowernumber` (`borrowernumber`),
>   KEY `categorycode` (`categorycode`),
>@@ -876,6 +877,7 @@ CREATE TABLE `deletedborrowers` ( -- stores data related to the patrons/borrower
>   `altcontactphone` varchar(50) default NULL, -- the phone number for the alternate contact for the patron/borrower
>   `smsalertnumber` varchar(50) default NULL, -- the mobile phone number where the patron/borrower would like to receive notices (if SNS turned on)
>   `privacy` integer(11) DEFAULT '1' NOT NULL, -- patron/borrower's privacy settings related to their reading history  KEY `borrowernumber` (`borrowernumber`),
>+  `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, -- time of last change could be useful for synchronization with external systems (among others)
>   KEY borrowernumber (borrowernumber),
>   KEY `cardnumber` (`cardnumber`)
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 5ada385..20cfffa 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -9438,6 +9438,18 @@ if ( CheckVersion($DBversion) ) {
>    SetVersion ($DBversion);
> }
> 
>+$DBversion = "3.17.00.XXX";
>+if ( CheckVersion($DBversion) ) {
>+    $dbh->do(q|
>+ALTER TABLE borrowers ADD COLUMN timestamp timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP AFTER privacy;
>+    |);
>+    $dbh->do(q|
>+ALTER TABLE deletedborrowers ADD COLUMN timestamp timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP AFTER privacy;
>+    |);
>+    print "Upgrade to $DBversion done (Bug 10459: Borrowers should have a timestamp)\n";
>+    SetVersion($DBversion);
>+}
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10459: 33421 | 33424 | 33435 | 33490 | 33491 | 33509 | 50475 | 50476 | 50478 | 50479 | 50480 | 50481 | 51807 | 51808 | 51809 | 51810 | 51842 | 51843 | 51844 | 51867 | 51868 | 52113 | 52114 | 52115 | 52294